refactor(tag): move set/unset refined tag to new func

Author: mydearxym

lib/helper/certification.ex

@@ -88,6 +88,7 @@ defmodule Helper.Certification do
         "post.tag.update",
         "post.tag.delete",
         "post.tag.set",
+        "post.refinedtag.set",
         "post.tag.unset",
         # post flag
         "post.pin",
@@ -99,17 +100,37 @@ defmodule Helper.Certification do
         "job.tag.update",
         "job.tag.delete",
         "job.tag.set",
+        "job.refinedtag.set",
         "job.tag.unset",
         # job flag
         "job.pin",
         "job.undo_pin",
         "job.trash",
         "job.undo_trash",
+        # video tag
+        "video.tag.create",
+        "video.tag.update",
+        "video.tag.delete",
+        "video.tag.set",
+        "video.refinedtag.set",
+        "video.tag.unset",
         # video flag
         "video.pin",
         "video.undo_pin",
         "video.trash",
-        "video.undo_trash"
+        "video.undo_trash",
+        # repo tag
+        "repo.tag.create",
+        "repo.tag.update",
+        "repo.tag.delete",
+        "repo.tag.set",
+        "repo.refinedtag.set",
+        "repo.tag.unset",
+        # repo flag
+        "repo.pin",
+        "repo.undo_pin",
+        "repo.trash",
+        "repo.undo_trash"
       ]
     }
   end

lib/mastani_server/cms/cms.ex

@@ -94,6 +94,10 @@ defmodule MastaniServer.CMS do
   # >> tag: set / unset
   defdelegate set_tag(community, thread, tag, content_id), to: ArticleOperation
   defdelegate unset_tag(thread, tag, content_id), to: ArticleOperation
+  defdelegate set_refined_tag(community, thread, topic, content_id), to: ArticleOperation
+  defdelegate set_refined_tag(community, thread, content_id), to: ArticleOperation
+  defdelegate unset_refined_tag(community, thread, topic, content_id), to: ArticleOperation
+  defdelegate unset_refined_tag(community, thread, content_id), to: ArticleOperation
   # >> community: set / unset
   defdelegate set_community(community, thread, content_id), to: ArticleOperation
   defdelegate unset_community(community, thread, content_id), to: ArticleOperation

lib/mastani_server/cms/delegates/article_operation.ex

@@ -151,17 +151,21 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
   end
 
   @doc """
-  set tag for post / tuts / videos ...
+  set general tag for post / tuts / videos ...
+  refined tag can't set by this func, use set_refined_tag instead
   """
   # check community first
   def set_tag(%Community{id: _communitId}, thread, %Tag{id: tag_id}, content_id) do
     with {:ok, action} <- match_action(thread, :tag),
          {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
          {:ok, tag} <- ORM.find(action.reactor, tag_id) do
-      content
-      |> Ecto.Changeset.change()
-      |> Ecto.Changeset.put_assoc(:tags, content.tags ++ [tag])
-      |> Repo.update()
+      case tag.title != "refined" do
+        true ->
+          update_content_tag(content, tag)
+
+        false ->
+          {:error, "use set_refined_tag instead"}
+      end
 
       # NOTE: this should be control by Middleware
       # case tag_in_community_thread?(%Community{id: communitId}, thread, tag) do
@@ -181,13 +185,71 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
     with {:ok, action} <- match_action(thread, :tag),
          {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
          {:ok, tag} <- ORM.find(action.reactor, tag_id) do
-      content
-      |> Ecto.Changeset.change()
-      |> Ecto.Changeset.put_assoc(:tags, content.tags -- [tag])
-      |> Repo.update()
+      update_content_tag(content, tag, :drop)
+    end
+  end
+
+  @doc """
+  set refined_tag to common content
+  """
+  def set_refined_tag(%Community{id: community_id}, thread, topic_raw, content_id) do
+    with {:ok, action} <- match_action(thread, :tag),
+         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
+         {:ok, topic} <- ORM.find_by(Topic, %{raw: topic_raw}),
+         {:ok, tag} <-
+           ORM.find_by(action.reactor, %{
+             title: "refined",
+             community_id: community_id,
+             topic_id: topic.id
+           }) do
+      update_content_tag(content, tag)
+    end
+  end
+
+  def set_refined_tag(%Community{id: community_id}, thread, content_id) do
+    with {:ok, action} <- match_action(thread, :tag),
+         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
+         {:ok, tag} <-
+           ORM.find_by(action.reactor, %{title: "refined", community_id: community_id}) do
+      update_content_tag(content, tag)
+    end
+  end
+
+  @doc """
+  unset refined_tag to common content
+  """
+  def unset_refined_tag(%Community{id: community_id}, thread, topic_raw, content_id) do
+    with {:ok, action} <- match_action(thread, :tag),
+         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
+         {:ok, topic} <- ORM.find_by(Topic, %{raw: topic_raw}),
+         {:ok, tag} <-
+           ORM.find_by(action.reactor, %{
+             title: "refined",
+             community_id: community_id,
+             topic_id: topic.id
+           }) do
+      update_content_tag(content, tag, :drop)
     end
   end
 
+  def unset_refined_tag(%Community{id: community_id}, thread, content_id) do
+    with {:ok, action} <- match_action(thread, :tag),
+         {:ok, content} <- ORM.find(action.target, content_id, preload: :tags),
+         {:ok, tag} <-
+           ORM.find_by(action.reactor, %{title: "refined", community_id: community_id}) do
+      update_content_tag(content, tag, :drop)
+    end
+  end
+
+  defp update_content_tag(content, %Tag{} = tag, opt \\ :add) do
+    new_tags = if opt == :add, do: content.tags ++ [tag], else: content.tags -- [tag]
+
+    content
+    |> Ecto.Changeset.change()
+    |> Ecto.Changeset.put_assoc(:tags, new_tags)
+    |> Repo.update()
+  end
+
   @doc """
   set topic only for post
   """

lib/mastani_server_web/resolvers/cms_resolver.ex

@@ -272,10 +272,26 @@ defmodule MastaniServerWeb.Resolvers.CMS do
     CMS.set_tag(%Community{id: community_id}, thread, %Tag{id: tag_id}, id)
   end
 
+  def set_refined_tag(_root, ~m(community_id thread id topic)a, _info) do
+    CMS.set_refined_tag(%Community{id: community_id}, thread, topic, id)
+  end
+
+  def set_refined_tag(_root, ~m(community_id thread id)a, _info) do
+    CMS.set_refined_tag(%Community{id: community_id}, thread, id)
+  end
+
   def unset_tag(_root, ~m(id thread tag_id)a, _info) do
     CMS.unset_tag(thread, %Tag{id: tag_id}, id)
   end
 
+  def unset_refined_tag(_root, ~m(community_id thread id topic)a, _info) do
+    CMS.unset_refined_tag(%Community{id: community_id}, thread, topic, id)
+  end
+
+  def unset_refined_tag(_root, ~m(community_id thread id)a, _info) do
+    CMS.unset_refined_tag(%Community{id: community_id}, thread, id)
+  end
+
   def get_tags(_root, %{community_id: community_id, all: true}, _info) do
     CMS.get_tags(%Community{id: community_id})
   end

lib/mastani_server_web/schema/cms/mutations/operation.ex

@@ -78,21 +78,35 @@ defmodule MastaniServerWeb.Schema.CMS.Mutations.Operation do
       resolve(&R.CMS.unsubscribe_community/3)
     end
 
-    @desc "set a tag within community"
+    @desc "set a tag to content"
     field :set_tag, :tag do
       arg(:id, non_null(:id))
       arg(:tag_id, non_null(:id))
       arg(:community_id, non_null(:id))
       arg(:thread, :cms_thread, default_value: :post)
 
       middleware(M.Authorize, :login)
-      # middleware(M.PassportLoader, source: :community)
-      # middleware(M.Passport, claim: "cms->c?->t?.tag.set")
+      middleware(M.PassportLoader, source: :community)
+      middleware(M.Passport, claim: "cms->c?->t?.tag.set")
 
       resolve(&R.CMS.set_tag/3)
     end
 
-    @desc "unset a tag within community"
+    @desc "set a refined tag to content"
+    field :set_refined_tag, :tag do
+      arg(:id, non_null(:id))
+      arg(:community_id, non_null(:id))
+      arg(:thread, :cms_thread, default_value: :post)
+      arg(:topic, :string)
+
+      middleware(M.Authorize, :login)
+      middleware(M.PassportLoader, source: :community)
+      middleware(M.Passport, claim: "cms->c?->t?.refinedtag.set")
+
+      resolve(&R.CMS.set_refined_tag/3)
+    end
+
+    @desc "unset a tag to content"
     field :unset_tag, :tag do
       # thread id
       arg(:id, non_null(:id))
@@ -101,12 +115,26 @@ defmodule MastaniServerWeb.Schema.CMS.Mutations.Operation do
       arg(:thread, :cms_thread, default_value: :post)
 
       middleware(M.Authorize, :login)
-      # middleware(M.PassportLoader, source: :community)
-      # middleware(M.Passport, claim: "cms->c?->t?.tag.unset")
+      middleware(M.PassportLoader, source: :community)
+      middleware(M.Passport, claim: "cms->c?->t?.tag.unset")
 
       resolve(&R.CMS.unset_tag/3)
     end
 
+    @desc "unset a refined tag to content"
+    field :unset_refined_tag, :tag do
+      arg(:id, non_null(:id))
+      arg(:community_id, non_null(:id))
+      arg(:thread, :cms_thread, default_value: :post)
+      arg(:topic, :string)
+
+      middleware(M.Authorize, :login)
+      middleware(M.PassportLoader, source: :community)
+      middleware(M.Passport, claim: "cms->c?->t?.refinedtag.set")
+
+      resolve(&R.CMS.unset_refined_tag/3)
+    end
+
     # TODO: use community loader
     field :set_community, :community do
       arg(:id, non_null(:id))

test/mastani_server_web/mutation/cms/job_test.exs

@@ -291,6 +291,15 @@ defmodule MastaniServer.Test.Mutation.Job do
       }
     }
     """
+    @set_refined_tag_query """
+    mutation($communityId: ID!, $thread: CmsThread, $topic: String, $id: ID!) {
+      setRefinedTag(communityId: $communityId, thread: $thread, topic: $topic, id: $id) {
+        id
+        title
+      }
+    }
+    """
+    @tag :wip
     test "auth user can set a valid tag to job", ~m(job)a do
       {:ok, community} = db_insert(:community)
       {:ok, tag} = db_insert(:tag, %{thread: "job", community: community})
@@ -300,10 +309,39 @@ defmodule MastaniServer.Test.Mutation.Job do
 
       variables = %{thread: "JOB", id: job.id, tagId: tag.id, communityId: community.id}
       rule_conn |> mutation_result(@set_tag_query, variables, "setTag")
-      # {:ok, found} = ORM.find(CMS.Job, job.id, preload: :tags)
+      {:ok, found} = ORM.find(CMS.Job, job.id, preload: :tags)
+
+      assoc_tags = found.tags |> Enum.map(& &1.id)
+      assert tag.id in assoc_tags
+    end
+
+    @tag :wip
+    test "can not set refined tag to job", ~m(job)a do
+      {:ok, community} = db_insert(:community)
+      {:ok, tag} = db_insert(:tag, %{thread: "job", community: community, title: "refined"})
+
+      passport_rules = %{community.title => %{"job.tag.set" => true}}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      variables = %{id: job.id, tagId: tag.id, communityId: community.id}
+
+      assert rule_conn |> mutation_get_error?(@set_tag_query, variables)
+    end
+
+    @tag :wip
+    test "auth user can set refined tag to job", ~m(job)a do
+      {:ok, community} = db_insert(:community)
+      {:ok, tag} = db_insert(:tag, %{thread: "job", community: community, title: "refined"})
+
+      passport_rules = %{community.title => %{"job.refinedtag.set" => true}}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      variables = %{id: job.id, communityId: community.id, thread: "JOB"}
+      rule_conn |> mutation_result(@set_refined_tag_query, variables, "setRefinedTag")
+      {:ok, found} = ORM.find(CMS.Job, job.id, preload: :tags)
 
-      # assoc_tags = found.tags |> Enum.map(& &1.id)
-      # assert tag.id in assoc_tags
+      assoc_tags = found.tags |> Enum.map(& &1.id)
+      assert tag.id in assoc_tags
     end
 
     # TODO: should fix in auth layer
@@ -338,5 +376,33 @@ defmodule MastaniServer.Test.Mutation.Job do
       assert tag.id in assoc_tags
       assert tag2.id in assoc_tags
     end
+
+    @unset_refined_tag_query """
+    mutation($communityId: ID!, $thread: CmsThread, $topic: String, $id: ID!) {
+      unsetRefinedTag(communityId: $communityId, thread: $thread, topic: $topic, id: $id) {
+        id
+        title
+      }
+    }
+    """
+    @tag :wip
+    test "can unset refined tag to a job", ~m(job)a do
+      {:ok, community} = db_insert(:community)
+      {:ok, tag} = db_insert(:tag, %{thread: "job", community: community, title: "refined"})
+
+      passport_rules = %{community.title => %{"job.refinedtag.set" => true}}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      variables = %{id: job.id, communityId: community.id, thread: "JOB"}
+      rule_conn |> mutation_result(@set_refined_tag_query, variables, "setRefinedTag")
+
+      variables = %{id: job.id, communityId: community.id, thread: "JOB"}
+      rule_conn |> mutation_result(@unset_refined_tag_query, variables, "unsetRefinedTag")
+
+      {:ok, found} = ORM.find(CMS.Job, job.id, preload: :tags)
+
+      assoc_tags = found.tags |> Enum.map(& &1.id)
+      assert tag.id not in assoc_tags
+    end
   end
 end