feat(post-qa): gq workflow

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -146,8 +146,11 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     article_comment |> ORM.update(%{body_html: content})
   end
 
-  def mark_comment_solution(article_comment_id, user) do
-    with {:ok, article_comment} <- ORM.find(ArticleComment, article_comment_id),
+  @doc """
+  mark a comment as question post's best solution
+  """
+  def mark_comment_solution(comment_id, user) do
+    with {:ok, article_comment} <- ORM.find(ArticleComment, comment_id),
          {:ok, post} <- ORM.find(Post, article_comment.post_id, preload: [author: :user]) do
       # 确保只有一个最佳答案
       batch_update_solution_flag(post, false)
@@ -156,8 +159,11 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     end
   end
 
-  def undo_mark_comment_solution(article_comment_id, user) do
-    with {:ok, article_comment} <- ORM.find(ArticleComment, article_comment_id),
+  @doc """
+  undo mark a comment as question post's best solution
+  """
+  def undo_mark_comment_solution(comment_id, user) do
+    with {:ok, article_comment} <- ORM.find(ArticleComment, comment_id),
          {:ok, post} <- ORM.find(Post, article_comment.post_id, preload: [author: :user]) do
       do_mark_comment_solution(post, article_comment, user, false)
     end
@@ -168,7 +174,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     with true <- user.id == post.author.user.id do
       Multi.new()
       |> Multi.run(:mark_solution, fn _, _ ->
-        ORM.update(article_comment, %{is_solution: is_solution})
+        ORM.update(article_comment, %{is_solution: is_solution, is_for_question: true})
       end)
       |> Multi.run(:update_post_state, fn _, _ ->
         ORM.update(post, %{is_solved: is_solution, solution_digest: article_comment.body_html})

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -320,6 +320,14 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.undo_emotion_to_comment(id, emotion, user)
   end
 
+  def mark_comment_solution(_root, ~m(id)a, %{context: %{cur_user: user}}) do
+    CMS.mark_comment_solution(id, user)
+  end
+
+  def undo_mark_comment_solution(_root, ~m(id)a, %{context: %{cur_user: user}}) do
+    CMS.undo_mark_comment_solution(id, user)
+  end
+
   ############
   ############
   ############

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -344,6 +344,9 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:is_deleted, :boolean)
     field(:viewer_has_upvoted, :boolean)
 
+    field(:is_for_question, :boolean)
+    field(:is_solution, :boolean)
+
     timestamp_fields()
   end
 

lib/groupher_server_web/schema/cms/mutations/comment.ex

@@ -73,6 +73,22 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Comment do
       resolve(&R.CMS.undo_emotion_to_comment/3)
     end
 
+    @desc "mark a comment as question post's best solution"
+    field :mark_comment_solution, :article_comment do
+      arg(:id, non_null(:id))
+
+      middleware(M.Authorize, :login)
+      resolve(&R.CMS.mark_comment_solution/3)
+    end
+
+    @desc "mark a comment as question post's best solution"
+    field :undo_mark_comment_solution, :article_comment do
+      arg(:id, non_null(:id))
+
+      middleware(M.Authorize, :login)
+      resolve(&R.CMS.undo_mark_comment_solution/3)
+    end
+
     ############################
     ############################
     ############################

test/groupher_server_web/mutation/cms/comments/post_comment_test.exs

@@ -219,4 +219,79 @@ defmodule GroupherServer.Test.Mutation.Comments.PostComment do
       assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
     end
   end
+
+  describe "[post only: article comment solution]" do
+    @query """
+    mutation($id: ID!) {
+      markCommentSolution(id: $id) {
+        id
+        isForQuestion
+        isSolution
+      }
+    }
+    """
+    @tag :wip
+    test "questioner can mark a post comment as solution", ~m(post)a do
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      post_author = post.author.user
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "solution", post_author)
+
+      questioner_conn = simu_conn(:user, post_author)
+
+      variables = %{id: comment.id}
+
+      result = questioner_conn |> mutation_result(@query, variables, "markCommentSolution")
+
+      assert result["isForQuestion"]
+      assert result["isSolution"]
+    end
+
+    @tag :wip
+    test "other user can not mark a post comment as solution", ~m(guest_conn user_conn post)a do
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      post_author = post.author.user
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "solution", post_author)
+
+      variables = %{id: comment.id}
+      assert user_conn |> mutation_get_error?(@query, variables, ecode(:require_questioner))
+      assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
+    end
+
+    @query """
+    mutation($id: ID!) {
+      undoMarkCommentSolution(id: $id) {
+        id
+        isForQuestion
+        isSolution
+      }
+    }
+    """
+    @tag :wip
+    test "questioner can undo mark a post comment as solution", ~m(post)a do
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      post_author = post.author.user
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "solution", post_author)
+      {:ok, comment} = CMS.mark_comment_solution(comment.id, post_author)
+
+      questioner_conn = simu_conn(:user, post_author)
+
+      variables = %{id: comment.id}
+      result = questioner_conn |> mutation_result(@query, variables, "undoMarkCommentSolution")
+
+      assert result["isForQuestion"]
+      assert not result["isSolution"]
+    end
+
+    @tag :wip
+    test "other user can not undo mark a post comment as solution",
+         ~m(guest_conn user_conn post)a do
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      post_author = post.author.user
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "solution", post_author)
+
+      variables = %{id: comment.id}
+      assert user_conn |> mutation_get_error?(@query, variables, ecode(:require_questioner))
+      assert guest_conn |> mutation_get_error?(@query, variables, ecode(:account_login))
+    end
+  end
 end

test/groupher_server_web/query/cms/comments/post_comment_test.exs

@@ -290,7 +290,7 @@ defmodule GroupherServer.Test.Query.Comments.PostComment do
       post_author = post.author.user
 
       {:ok, comment} = CMS.create_article_comment(thread, post.id, "pinned comment", user)
-      {:ok, pinned_comment} = CMS.pin_article_comment(comment.id)
+      {:ok, _pinned_comment} = CMS.pin_article_comment(comment.id)
 
       Process.sleep(1000)
 
@@ -299,7 +299,7 @@ defmodule GroupherServer.Test.Query.Comments.PostComment do
 
       Process.sleep(1000)
       {:ok, comment} = CMS.create_article_comment(thread, post.id, "pinned comment 2", user)
-      {:ok, pinned_comment2} = CMS.pin_article_comment(comment.id)
+      {:ok, _pinned_comment2} = CMS.pin_article_comment(comment.id)
 
       variables = %{id: post.id, thread: "POST", filter: %{page: 1, size: 10}}
       results = guest_conn |> query_result(@query, variables, "pagedArticleComments")