chore(clean up): rm warnings & wip tag

Author: mydearxym

lib/mastani_server/accounts/delegates/achievements.ex

@@ -106,7 +106,6 @@ defmodule MastaniServer.Accounts.Delegate.Achievements do
 
   def do_set_member(%User{id: user_id}, attrs) do
     with {:ok, achievement} <- ORM.findby_or_insert(Achievement, ~m(user_id)a, ~m(user_id)a) do
-      IO.inspect(attrs, label: "hello attrs")
       achievement |> ORM.update(attrs)
     end
   end

test/mastani_server/accounts/customization_test.exs

@@ -12,23 +12,19 @@ defmodule MastaniServer.Test.Accounts.Customization do
   end
 
   describe "[user customization]" do
-    @tag :wip
     test "user can have default customization without payment", ~m(user)a do
       {:ok, result} = Accounts.set_customization(user, :banner_layout, "digest")
       assert result.banner_layout == "digest"
     end
 
-    @tag :wip
     test "user set non exsit customization fails", ~m(user)a do
       {:error, _} = Accounts.set_customization(user, :non_exsit, true)
     end
 
-    @tag :wip2
     test "user set advance customization without payment fails", ~m(user)a do
       {:error, _} = Accounts.set_customization(user, :theme, "blue")
     end
 
-    @tag :wip2
     test "user can set multiable customization at once", ~m(user)a do
       {:ok, result} =
         Accounts.set_customization(user, %{

test/mastani_server/billing/billing_test.exs

@@ -18,7 +18,6 @@ defmodule MastaniServer.Test.Billing do
   end
 
   describe "[billing curd]" do
-    @tag :wip
     test "create bill record with valid attrs", ~m(user valid_attrs)a do
       {:ok, record} = Billing.create_record(user, valid_attrs)
 
@@ -29,29 +28,25 @@ defmodule MastaniServer.Test.Billing do
       assert String.length(record.hash_id) == 8
     end
 
-    @tag :wip
     test "create bill record with valid note", ~m(user valid_attrs)a do
       {:ok, record} = Billing.create_record(user, valid_attrs |> Map.merge(%{note: "i am girl"}))
 
       assert record.note == "i am girl"
     end
 
-    @tag :wip
     test "create bill record with previous record unhandled fails", ~m(user valid_attrs)a do
       {:ok, _record} = Billing.create_record(user, valid_attrs)
       {:error, error} = Billing.create_record(user, valid_attrs)
       assert error |> Keyword.get(:code) == ecode(:exsit_pending_bill)
     end
 
-    @tag :wip
     test "record state can be update", ~m(user valid_attrs)a do
       {:ok, record} = Billing.create_record(user, valid_attrs)
 
       {:ok, updated} = Billing.update_record_state(record.id, :done)
       assert updated.state == "done"
     end
 
-    @tag :wip
     test "can get paged bill records of a user", ~m(user valid_attrs)a do
       {:ok, _record} = Billing.create_record(user, valid_attrs)
 
@@ -63,45 +58,41 @@ defmodule MastaniServer.Test.Billing do
   end
 
   describe "[after billing]" do
-    @tag :wip
     test "user updgrade to seninor_member after seninor bill handled", ~m(user valid_attrs)a do
       attrs = valid_attrs |> Map.merge(%{amount: @seninor_amount_threshold})
 
       {:ok, record} = Billing.create_record(user, attrs)
-      {:ok, updated} = Billing.update_record_state(record.id, :done)
+      {:ok, _updated} = Billing.update_record_state(record.id, :done)
 
       {:ok, %{achievement: achievement}} = ORM.find(User, user.id, preload: :achievement)
       assert achievement.seninor_member == true
     end
 
-    @tag :wip
     test "user updgrade to donate_member after donate bill handled", ~m(user valid_attrs)a do
       attrs = valid_attrs |> Map.merge(%{amount: @seninor_amount_threshold - 10})
 
       {:ok, record} = Billing.create_record(user, attrs)
-      {:ok, updated} = Billing.update_record_state(record.id, :done)
+      {:ok, _updated} = Billing.update_record_state(record.id, :done)
 
       {:ok, %{achievement: achievement}} = ORM.find(User, user.id, preload: :achievement)
       assert achievement.donate_member == true
     end
 
-    @tag :wip
     test "girls updgrade to seninor_member after bill handled", ~m(user valid_attrs)a do
       attrs = valid_attrs |> Map.merge(%{amount: 0, payment_usage: "girls_code_too_plan"})
 
       {:ok, record} = Billing.create_record(user, attrs)
-      {:ok, updated} = Billing.update_record_state(record.id, :done)
+      {:ok, _updated} = Billing.update_record_state(record.id, :done)
 
       {:ok, %{achievement: achievement}} = ORM.find(User, user.id, preload: :achievement)
       assert achievement.seninor_member == true
     end
 
-    @tag :wip
     test "sponsor updgrade to seninor_member after bill handled", ~m(user valid_attrs)a do
       attrs = valid_attrs |> Map.merge(%{amount: 0, payment_usage: "sponsor"})
 
       {:ok, record} = Billing.create_record(user, attrs)
-      {:ok, updated} = Billing.update_record_state(record.id, :done)
+      {:ok, _updated} = Billing.update_record_state(record.id, :done)
 
       {:ok, %{achievement: achievement}} = ORM.find(User, user.id, preload: :achievement)
       assert achievement.sponsor_member == true

test/mastani_server_web/mutation/billing/billing_test.exs

@@ -31,8 +31,7 @@ defmodule MastaniServer.Test.Mutation.Billing.Basic do
       }
     }
     """
-    @tag :wip
-    test "auth user can create bill", ~m(user user_conn valid_attrs)a do
+    test "auth user can create bill", ~m(user_conn valid_attrs)a do
       variables = valid_attrs |> camelize_map_key(:upcase)
 
       created = user_conn |> mutation_result(@create_query, variables, "createBill")
@@ -49,7 +48,6 @@ defmodule MastaniServer.Test.Mutation.Billing.Basic do
       }
     }
     """
-    @tag :wip
     test "auth user can update bill state", ~m(user valid_attrs)a do
       {:ok, record} = Billing.create_record(user, valid_attrs)
 

test/mastani_server_web/query/billing/billing_test.exs

@@ -37,8 +37,6 @@ defmodule MastaniServer.Test.Query.Billing.Basic do
       }
     }
     """
-
-    @tag :wip
     test "login user can get it's own billing records ", ~m(user_conn user valid_attrs)a do
       {:ok, _record} = Billing.create_record(user, valid_attrs)
 

test/mastani_server_web/query/cms/paged_posts_test.exs

@@ -122,7 +122,7 @@ defmodule MastaniServer.Test.Query.PagedPosts do
       variables = %{filter: %{}}
       results = guest_conn |> query_result(@query, variables, "pagedPosts")
       inserted_timestamps = results["entries"] |> Enum.map(& &1["inserted_at"])
-      IO.inspect(inserted_timestamps, label: "inserted_timestamps")
+      # IO.inspect(inserted_timestamps, label: "inserted_timestamps")
 
       {:ok, first_inserted_time, 0} =
         inserted_timestamps |> List.first() |> DateTime.from_iso8601()

test/mastani_server_web/query/cms/post_comment_test.exs

@@ -153,7 +153,7 @@ defmodule MastaniServer.Test.Query.PostComment do
       results = guest_conn |> query_result(@query, variables, "pagedPosts")
 
       # for test window function
-      commentsParticipators = results["entries"]
+      _commentsParticipators = results["entries"]
       # IO.inspect(commentsParticipators, label: "commentsParticipators->")
     end