refactor(notify): wip

Author: mydearxym

lib/groupher_server/accounts/accounts.ex

@@ -8,6 +8,7 @@ defmodule GroupherServer.Accounts do
     CollectFolder,
     Publish,
     Mails,
+    Mailbox,
     Profile,
     UpvotedArticles,
     Search,
@@ -74,6 +75,8 @@ defmodule GroupherServer.Accounts do
   defdelegate mark_mail_read_all(user, opt), to: Mails
   defdelegate mark_mail_read(mail, user), to: Mails
 
+  defdelegate update_mailbox_status(user_id), to: Mailbox
+
   # customization
   defdelegate get_customization(user), to: Customization
   defdelegate set_customization(user, key, value), to: Customization

lib/groupher_server/accounts/delegates/mailbox.ex

@@ -0,0 +1,25 @@
+defmodule GroupherServer.Accounts.Delegate.Mailbox do
+  import Ecto.Query, warn: false
+
+  alias GroupherServer.{Accounts, Delivery}
+  alias Accounts.Model.User
+  alias Helper.ORM
+
+  def update_mailbox_status(user_id) do
+    with {:ok, user} <- ORM.find(User, user_id),
+         {:ok, unread_mentions_count} <- Delivery.unread_count(:mention, user_id),
+         {:ok, unread_notifications_count} <- Delivery.unread_count(:notification, user_id) do
+      unread_total_count = unread_mentions_count + unread_notifications_count
+      is_empty = unread_total_count < 1
+
+      mailbox = %{
+        unread_mentions_count: unread_mentions_count,
+        unread_notifications_count: unread_notifications_count,
+        unread_total_count: unread_total_count,
+        is_empty: is_empty
+      }
+
+      user |> ORM.update_embed(:mailbox, mailbox)
+    end
+  end
+end

lib/groupher_server/accounts/models/embeds/user_mailbox.ex

@@ -0,0 +1,22 @@
+defmodule GroupherServer.Accounts.Model.Embeds.UserMailbox do
+  @moduledoc """
+  general article meta info for articles
+  """
+  use Ecto.Schema
+  use Accessible
+
+  import Ecto.Changeset
+
+  @optional_fields ~w(reported_count)a
+
+  embedded_schema do
+    field(:is_empty, :boolean, default: false)
+    field(:unread_total_count, :integer, default: 0)
+    field(:unread_mentions_count, :integer, default: 0)
+    field(:unread_notifications_count, :integer, default: 0)
+  end
+
+  def changeset(struct, params) do
+    struct |> cast(params, @optional_fields)
+  end
+end

lib/groupher_server/accounts/models/user.ex

@@ -74,6 +74,7 @@ defmodule GroupherServer.Accounts.Model.User do
 
     embeds_one(:meta, Embeds.UserMeta, on_replace: :update)
     embeds_one(:contributes, Embeds.UserContribute, on_replace: :update)
+    embeds_one(:mailbox, Embeds.UserMailbox, on_replace: :update)
 
     has_one(:customization, Customization)
     has_one(:purchase, Purchase)
@@ -97,6 +98,7 @@ defmodule GroupherServer.Accounts.Model.User do
     |> cast_embed(:education_backgrounds, with: &EducationBackground.changeset/2)
     |> cast_embed(:work_backgrounds, with: &WorkBackground.changeset/2)
     |> cast_embed(:meta, required: false, with: &Embeds.UserMeta.changeset/2)
+    |> cast_embed(:mailbox, required: false, with: &Embeds.UserMailbox.changeset/2)
     |> validate_length(:nickname, min: 3, max: 30)
     |> validate_length(:bio, min: 3, max: 100)
     |> validate_inclusion(:sex, ["dude", "girl"])

lib/groupher_server/delivery/delegates/mention.ex

@@ -47,9 +47,13 @@ defmodule GroupherServer.Delivery.Delegate.Mention do
       batch_delete_mentions(article, from_user)
     end)
     |> Multi.run(:batch_insert_mentions, fn _, _ ->
-      mentions = Enum.map(mentions, &atom_values_to_upcase(&1))
+      mentions =
+        mentions
+        |> Enum.map(&atom_values_to_upcase(&1))
+        # ignore mention myself
+        |> Enum.reject(&(&1.to_user_id == from_user.id))
 
-      case {0, nil} !== Repo.insert_all(Mention, mentions) do
+      case Enum.empty?(mentions) or {0, nil} !== Repo.insert_all(Mention, mentions) do
         true -> {:ok, :pass}
         false -> {:error, "insert mentions error"}
       end
@@ -58,6 +62,7 @@ defmodule GroupherServer.Delivery.Delegate.Mention do
     |> result()
   end
 
+  @doc "paged mentions"
   def paged_mentions(%User{} = user, %{page: page, size: size} = filter) do
     read = Map.get(filter, :read, false)
 
@@ -69,6 +74,25 @@ defmodule GroupherServer.Delivery.Delegate.Mention do
     |> done()
   end
 
+  @doc "get unread mentions count"
+  def unread_count(user_id) do
+    Mention
+    |> where([m], m.to_user_id == ^user_id and m.read == false)
+    |> Repo.aggregate(:count)
+    |> done
+  end
+
+  def mark_read(ids, %User{} = user) when is_list(ids) do
+    query = Mention |> where([m], m.id in ^ids and m.to_user_id == ^user.id and m.read == false)
+
+    result = Repo.update_all(query, set: [read: true])
+
+    case result do
+      {0, nil} -> {:error, "no such mentions found"}
+      _ -> {:ok, :done}
+    end
+  end
+
   defp batch_delete_mentions(%Comment{} = comment, %User{} = from_user) do
     from(m in Mention,
       where: m.comment_id == ^comment.id,
@@ -100,6 +124,7 @@ defmodule GroupherServer.Delivery.Delegate.Mention do
 
     mention
     |> Map.take([
+      :id,
       :thread,
       :article_id,
       :comment_id,

lib/groupher_server/delivery/delegates/notification.ex

@@ -64,7 +64,15 @@ defmodule GroupherServer.Delivery.Delegate.Notification do
     |> where([n], n.user_id == ^user_id)
     |> where([n], n.read == ^read)
     |> ORM.paginater(~m(page size)a)
-    |> done()
+    |> done
+  end
+
+  # 注意这里并不是准确的 count, 因为可能有短时间内 merge 到一起的通知
+  def unread_count(user_id) do
+    Notification
+    |> where([n], n.user_id == ^user_id and n.read == false)
+    |> Repo.aggregate(:count)
+    |> done
   end
 
   # 如果在临近时间段内有类似操作，直接将这次的操作人添加到 from_users 中即可

lib/groupher_server/delivery/delegates/postman.ex

@@ -14,6 +14,13 @@ defmodule GroupherServer.Delivery.Delegate.Postman do
   def fetch(:mention, user, filter), do: Mention.paged_mentions(user, filter)
   def fetch(:notification, user, filter), do: Notification.paged_notifications(user, filter)
 
+  def unread_count(:mention, user_id), do: Mention.unread_count(user_id)
+  def unread_count(:notification, user_id), do: Notification.unread_count(user_id)
+
+  def mark_read(:mention, ids, user), do: Mention.mark_read(ids, user)
+  # def mark_read(:mention, ids, user), do: false
+  # def mark_read_all(:mention, id, user), do: false
+
   # def send(_, _, _), do: {:error, "delivery, not such service"}
   # def send(_, _, _, _), do: {:error, "delivery, not such service"}
 end

lib/groupher_server/delivery/delivery.ex

@@ -12,7 +12,9 @@ defmodule GroupherServer.Delivery do
   defdelegate send(service, attrs, from_user), to: Postman
   defdelegate revoke(service, attrs, from_user), to: Postman
   defdelegate fetch(service, user, filter), to: Postman
+  defdelegate unread_count(service, user), to: Postman
 
+  defdelegate mark_read(service, ids, user), to: Postman
   # system_notifications
   defdelegate publish_system_notification(info), to: Notifications
   defdelegate fetch_sys_notifications(user, filter), to: Notifications

lib/groupher_server/delivery/models/mention.ex

@@ -34,4 +34,8 @@ defmodule GroupherServer.Delivery.Model.Mention do
     |> foreign_key_constraint(:from_user_id)
     |> foreign_key_constraint(:to_user_id)
   end
+
+  def update_changeset(%Mention{} = mention, attrs) do
+    mention |> cast(attrs, @optional_fields ++ @required_fields)
+  end
 end

priv/repo/migrations/20210621041646_add_mailbox_to_user.exs

@@ -0,0 +1,9 @@
+defmodule GroupherServer.Repo.Migrations.AddMailboxToUser do
+  use Ecto.Migration
+
+  def change do
+    alter table(:users) do
+      add(:mailbox, :map)
+    end
+  end
+end