refactor: fix test error

Author: mydearxym

lib/groupher_server/cms/delegates/article_operation.ex

@@ -121,7 +121,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
          {:ok, article} <-
            ORM.find(info.model, article_id, preload: [:communities, :original_community]),
          {:ok, community} <- ORM.find(Community, community_id) do
-      case article.original_community.id == community_id do
+      case article.original_community.id == community.id do
         true ->
           raise_error(:mirror_community, "can not unmirror original_community")
 

test/groupher_server/cms/article_community/job_test.exs

@@ -18,15 +18,13 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
   end
 
   describe "[article mirror/move]" do
-    @tag :wip2
     test "created job has origial community info", ~m(user community job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
       {:ok, job} = ORM.find(CMS.Job, job.id, preload: :original_community)
 
       assert job.original_community_id == community.id
     end
 
-    @tag :wip2
     test "job can be move to other community", ~m(user community community2 job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
       assert job.original_community_id == community.id
@@ -37,7 +35,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
       assert job.original_community.id == community2.id
     end
 
-    @tag :wip2
     test "job can be mirror to other community", ~m(user community community2 job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
 
@@ -54,7 +51,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
       assert not is_nil(Enum.find(job.communities, &(&1.id == community2.id)))
     end
 
-    @tag :wip2
     test "job can be unmirror from community",
          ~m(user community community2 community3 job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
@@ -71,7 +67,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
       assert is_nil(Enum.find(job.communities, &(&1.id == community3.id)))
     end
 
-    @tag :wip2
     test "job can not unmirror from original community",
          ~m(user community community2 community3 job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)

test/groupher_server/cms/article_community/post_test.exs

@@ -18,15 +18,13 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
   end
 
   describe "[article mirror/move]" do
-    @tag :wip2
     test "created post has origial community info", ~m(user community post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
       {:ok, post} = ORM.find(CMS.Post, post.id, preload: :original_community)
 
       assert post.original_community_id == community.id
     end
 
-    @tag :wip2
     test "post can be move to other community", ~m(user community community2 post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
       assert post.original_community_id == community.id
@@ -37,7 +35,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
       assert post.original_community.id == community2.id
     end
 
-    @tag :wip2
     test "post can be mirror to other community", ~m(user community community2 post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
@@ -54,7 +51,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
       assert not is_nil(Enum.find(post.communities, &(&1.id == community2.id)))
     end
 
-    @tag :wip2
     test "post can be unmirror from community",
          ~m(user community community2 community3 post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -71,7 +67,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
       assert is_nil(Enum.find(post.communities, &(&1.id == community3.id)))
     end
 
-    @tag :wip2
     test "post can not unmirror from original community",
          ~m(user community community2 community3 post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)

test/groupher_server/cms/article_community/repo_test.exs

@@ -18,15 +18,13 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
   end
 
   describe "[article mirror/move]" do
-    @tag :wip2
     test "created repo has origial community info", ~m(user community repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
       {:ok, repo} = ORM.find(CMS.Repo, repo.id, preload: :original_community)
 
       assert repo.original_community_id == community.id
     end
 
-    @tag :wip2
     test "repo can be move to other community", ~m(user community community2 repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
       assert repo.original_community_id == community.id
@@ -37,7 +35,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
       assert repo.original_community.id == community2.id
     end
 
-    @tag :wip2
     test "repo can be mirror to other community", ~m(user community community2 repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
 
@@ -54,7 +51,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
       assert not is_nil(Enum.find(repo.communities, &(&1.id == community2.id)))
     end
 
-    @tag :wip2
     test "repo can be unmirror from community",
          ~m(user community community2 community3 repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
@@ -71,7 +67,6 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
       assert is_nil(Enum.find(repo.communities, &(&1.id == community3.id)))
     end
 
-    @tag :wip2
     test "repo can not unmirror from original community",
          ~m(user community community2 community3 repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)

test/groupher_server_web/mutation/cms/articles/post_test.exs

@@ -464,6 +464,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       }
     }
     """
+    @tag :wip2
     test "auth user can unset community from a post", ~m(post)a do
       passport_rules = %{"post.community.set" => true}
       rule_conn = simu_conn(:user, cms: passport_rules)

test/support/factory.ex

@@ -22,6 +22,7 @@ defmodule GroupherServer.Support.Factory do
       length: String.length(body),
       author: mock(:author),
       views: Enum.random(0..2000),
+      original_community: mock(:community),
       communities: [
         mock(:community),
         mock(:community)
@@ -58,6 +59,7 @@ defmodule GroupherServer.Support.Factory do
       ],
       author: mock(:author),
       views: Enum.random(0..2000),
+      original_community: mock(:community),
       communities: [
         mock(:community),
         mock(:community)
@@ -123,6 +125,7 @@ defmodule GroupherServer.Support.Factory do
       field: field_enum |> Enum.at(Enum.random(0..(length(field_enum) - 1))),
       finance: finance_enum |> Enum.at(Enum.random(0..(length(finance_enum) - 1))),
       scale: scale_enum |> Enum.at(Enum.random(0..(length(scale_enum) - 1))),
+      original_community: mock(:community),
       communities: [
         mock(:community)
       ],