chore: update pkgs & rm all rest warnings

Author: mydearxym

lib/helper/radar_search.ex

@@ -48,7 +48,7 @@ defmodule Helper.RadarSearch do
   end
 
   # not valid io, just ignore it
-  def locate_city(_ip), do: {:error, "invalid ip"}
+  # def locate_city(_ip), do: {:error, "invalid ip"}
 
   defp handle_result({:ok, result}) do
     case result do

lib/mastani_server/accounts/delegates/achievements.ex

@@ -121,16 +121,16 @@ defmodule MastaniServer.Accounts.Delegate.Achievements do
     end
   end
 
-  @spec safe_minus(non_neg_integer(), non_neg_integer()) :: non_neg_integer()
-  defp safe_minus(count, unit) when is_integer(count) and is_integer(unit) and unit > 0 do
-    case count <= 0 do
-      true ->
-        0
-
-      false ->
-        count - unit
-    end
-  end
+  # @spec safe_minus(non_neg_integer(), non_neg_integer()) :: non_neg_integer()
+  # defp safe_minus(count, unit) when is_integer(count) and is_integer(unit) and unit > 0 do
+  # case count <= 0 do
+  # true ->
+  # 0
+
+  # false ->
+  # count - unit
+  # end
+  # end
 
   @doc """
   list communities which the user is editor in it

lib/mastani_server/accounts/delegates/mails.ex

@@ -13,7 +13,7 @@ defmodule MastaniServer.Accounts.Delegate.Mails do
   def fetch_mentions(%User{} = user, filter) do
     with {:ok, mentions} <- Delivery.fetch_mentions(user, filter),
          {:ok, washed_mentions} <- wash_data(MentionMail, mentions.entries) do
-      result = MentionMail |> Repo.insert_all(washed_mentions)
+      MentionMail |> Repo.insert_all(washed_mentions)
       MentionMail |> messages_fetcher(washed_mentions, user, filter)
     end
   end
@@ -43,7 +43,7 @@ defmodule MastaniServer.Accounts.Delegate.Mails do
     end
   end
 
-  defp messages_fetcher(queryable, washed_data, %User{id: user_id}, %{
+  defp messages_fetcher(queryable, _washed_data, %User{id: user_id}, %{
          page: page,
          size: size,
          read: read

lib/mastani_server/cms/delegates/article_curd.ex

@@ -132,7 +132,7 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
     {:error, [message: "set community flag", code: ecode(:create_fails)]}
   end
 
-  defp create_content_result({:error, :set_topic, result, _steps}) do
+  defp create_content_result({:error, :set_topic, _result, _steps}) do
     {:error, [message: "set topic", code: ecode(:create_fails)]}
   end
 
@@ -227,7 +227,7 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
         |> join(:inner, [p], content in assoc(p, :post))
         |> where(
           [p, c, t, content],
-          c.raw == ^filter.community and t.raw == ^Map.get(filter, :topic, "posts")
+          c.raw == ^community and t.raw == ^Map.get(filter, :topic, "posts")
         )
         |> select([p, c, t, content], content)
         # 10 pined contents per community/thread, at most
@@ -241,19 +241,21 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
     end
   end
 
-  defp add_pin_contents_ifneed(contents, CMS.Job, %{community: community} = filter) do
+  defp add_pin_contents_ifneed(contents, CMS.Job, %{community: _community} = filter) do
     merge_pin_contents(contents, :job, CMS.PinedJob, filter)
   end
 
-  defp add_pin_contents_ifneed(contents, CMS.Video, %{community: community} = filter) do
+  defp add_pin_contents_ifneed(contents, CMS.Video, %{community: _community} = filter) do
     merge_pin_contents(contents, :video, CMS.PinedVideo, filter)
   end
 
-  defp add_pin_contents_ifneed(contents, CMS.Repo, %{community: community} = filter) do
+  defp add_pin_contents_ifneed(contents, CMS.Repo, %{community: _community} = filter) do
     merge_pin_contents(contents, :repo, CMS.PinedRepo, filter)
   end
 
-  defp merge_pin_contents(contents, thread, pin_schema, %{community: community} = filter) do
+  defp add_pin_contents_ifneed(contents, _querable, _filter), do: contents
+
+  defp merge_pin_contents(contents, thread, pin_schema, %{community: _community} = filter) do
     with {:ok, normal_contents} <- contents,
          true <- Map.has_key?(filter, :community),
          true <- 1 == Map.get(normal_contents, :page_number) do
@@ -274,8 +276,6 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
     end
   end
 
-  defp add_pin_contents_ifneed(contents, _querable, _filter), do: contents
-
   defp concat_contents(pined_content, normal_contents) do
     case pined_content |> Map.get(:total_count) do
       0 ->

lib/mastani_server/cms/delegates/article_operation.ex

@@ -41,14 +41,6 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
     end
   end
 
-  def undo_pin_content(%Post{id: post_id}, %Community{id: community_id}, topic) do
-    with {:ok, %{id: topic_id}} <- ORM.find_by(Topic, %{raw: topic}),
-         {:ok, pined} <- ORM.find_by(PinedPost, ~m(post_id community_id topic_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      Post |> ORM.find(deleted.post_id)
-    end
-  end
-
   def pin_content(%Job{id: job_id}, %Community{id: community_id}) do
     attrs = ~m(job_id community_id)a
 
@@ -57,13 +49,6 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
     end
   end
 
-  def undo_pin_content(%Job{id: job_id}, %Community{id: community_id}) do
-    with {:ok, pined} <- ORM.find_by(PinedJob, ~m(job_id community_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      Job |> ORM.find(deleted.job_id)
-    end
-  end
-
   def pin_content(%Video{id: video_id}, %Community{id: community_id}) do
     attrs = ~m(video_id community_id)a
 
@@ -72,13 +57,6 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
     end
   end
 
-  def undo_pin_content(%Video{id: video_id}, %Community{id: community_id}) do
-    with {:ok, pined} <- ORM.find_by(PinedVideo, ~m(video_id community_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      Video |> ORM.find(deleted.video_id)
-    end
-  end
-
   def pin_content(%CMSRepo{id: repo_id}, %Community{id: community_id}) do
     attrs = ~m(repo_id community_id)a
 
@@ -87,6 +65,28 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
     end
   end
 
+  def undo_pin_content(%Post{id: post_id}, %Community{id: community_id}, topic) do
+    with {:ok, %{id: topic_id}} <- ORM.find_by(Topic, %{raw: topic}),
+         {:ok, pined} <- ORM.find_by(PinedPost, ~m(post_id community_id topic_id)a),
+         {:ok, deleted} <- ORM.delete(pined) do
+      Post |> ORM.find(deleted.post_id)
+    end
+  end
+
+  def undo_pin_content(%Job{id: job_id}, %Community{id: community_id}) do
+    with {:ok, pined} <- ORM.find_by(PinedJob, ~m(job_id community_id)a),
+         {:ok, deleted} <- ORM.delete(pined) do
+      Job |> ORM.find(deleted.job_id)
+    end
+  end
+
+  def undo_pin_content(%Video{id: video_id}, %Community{id: community_id}) do
+    with {:ok, pined} <- ORM.find_by(PinedVideo, ~m(video_id community_id)a),
+         {:ok, deleted} <- ORM.delete(pined) do
+      Video |> ORM.find(deleted.video_id)
+    end
+  end
+
   def undo_pin_content(%CMSRepo{id: repo_id}, %Community{id: community_id}) do
     with {:ok, pined} <- ORM.find_by(PinedRepo, ~m(repo_id community_id)a),
          {:ok, deleted} <- ORM.delete(pined) do
@@ -222,16 +222,16 @@ defmodule MastaniServer.CMS.Delegate.ArticleOperation do
 
   # make sure the reuest tag is in the current community thread
   # example: you can't set a other thread tag to this thread's article
-  defp tag_in_community_thread?(%Community{id: communityId}, thread, tag) do
-    with {:ok, community} <- ORM.find(Community, communityId) do
-      matched_tags =
-        Tag
-        |> where([t], t.community_id == ^community.id)
-        # |> where([t], t.thread == ^(to_string(thread) |> String.upcase()))
-        |> where([t], t.thread == ^to_string(thread))
-        |> Repo.all()
-
-      tag in matched_tags
-    end
-  end
+
+  # defp tag_in_community_thread?(%Community{id: communityId}, thread, tag) do
+  # with {:ok, community} <- ORM.find(Community, communityId) do
+  # matched_tags =
+  # Tag
+  # |> where([t], t.community_id == ^community.id)
+  # |> where([t], t.thread == ^to_string(thread))
+  # |> Repo.all()
+
+  # tag in matched_tags
+  # end
+  # end
 end

lib/mastani_server/cms/delegates/community_curd.ex

@@ -73,7 +73,7 @@ defmodule MastaniServer.CMS.Delegate.CommunityCURD do
 
     with {:ok, %{id: topic_id}} = find_or_insert_topic(attrs) do
       Tag
-      |> ORM.find_update(~m(id title color color topic_id)a)
+      |> ORM.find_update(~m(id title color topic_id)a)
     end
   end
 

lib/mastani_server/cms/delegates/passport_curd.ex

@@ -30,7 +30,7 @@ defmodule MastaniServer.CMS.Delegate.PassportCURD do
         {:ok, passport} ->
           {:ok, passport.rules}
 
-        {:error, error} ->
+        {:error, _error} ->
           {:ok, %{}}
       end
     end

lib/mastani_server/cms/delegates/search.ex

@@ -14,7 +14,7 @@ defmodule MastaniServer.CMS.Delegate.Search do
   @doc """
   search community by title
   """
-  def search_items(:community, %{title: title} = args) do
+  def search_items(:community, %{title: title} = _args) do
     Community
     |> where([c], ilike(c.title, ^"%#{title}%") or ilike(c.raw, ^"%#{title}%"))
     |> ORM.paginater(page: 1, size: @search_items_count)
@@ -24,7 +24,7 @@ defmodule MastaniServer.CMS.Delegate.Search do
   @doc """
   search post by title
   """
-  def search_items(:post, %{title: title} = args) do
+  def search_items(:post, %{title: title} = _args) do
     Post
     |> where([c], ilike(c.title, ^"%#{title}%") or ilike(c.digest, ^"%#{title}%"))
     |> ORM.paginater(page: 1, size: @search_items_count)
@@ -34,7 +34,7 @@ defmodule MastaniServer.CMS.Delegate.Search do
   @doc """
   search job by title or company name
   """
-  def search_items(:job, %{title: title} = args) do
+  def search_items(:job, %{title: title} = _args) do
     Job
     |> where([c], ilike(c.title, ^"%#{title}%") or ilike(c.company, ^"%#{title}%"))
     |> ORM.paginater(page: 1, size: @search_items_count)
@@ -44,7 +44,7 @@ defmodule MastaniServer.CMS.Delegate.Search do
   @doc """
   search video by title
   """
-  def search_items(:video, %{title: title} = args) do
+  def search_items(:video, %{title: title} = _args) do
     Video
     |> where([c], ilike(c.title, ^"%#{title}%") or ilike(c.desc, ^"%#{title}%"))
     |> ORM.paginater(page: 1, size: @search_items_count)
@@ -54,7 +54,7 @@ defmodule MastaniServer.CMS.Delegate.Search do
   @doc """
   search repo by title
   """
-  def search_items(:repo, %{title: title} = args) do
+  def search_items(:repo, %{title: title} = _args) do
     Repo
     |> where([c], ilike(c.title, ^"%#{title}%") or ilike(c.owner_name, ^"%#{title}%"))
     |> ORM.paginater(page: 1, size: @search_items_count)

lib/mastani_server/cms/delegates/seeds_config.ex

@@ -326,6 +326,8 @@ defmodule MastaniServer.CMS.Delegate.SeedsConfig do
     |> Enum.map(fn attr -> Map.merge(%{thread: :video, topic: "videos"}, attr) end)
   end
 
+  def tags(_), do: []
+
   def tags(:city, :post) do
     [
       %{
@@ -529,7 +531,6 @@ defmodule MastaniServer.CMS.Delegate.SeedsConfig do
     |> Enum.map(fn attr -> Map.merge(%{thread: :job, topic: "jobs"}, attr) end)
   end
 
-  def tags(_), do: []
   def tags(:home, _), do: []
 
   defp city_tags do

lib/mastani_server/cms/post.ex

@@ -88,12 +88,4 @@ defmodule MastaniServer.CMS.Post do
     # |> foreign_key_constraint(:posts_tags, name: :posts_tags_tag_id_fkey)
     # |> foreign_key_constraint(name: :posts_tags_tag_id_fkey)
   end
-
-  @doc """
-  for update flag
-  """
-  # def flag_changeset(%Post{} = post, attrs) do
-  # post
-  # |> cast(attrs, ~w(pin trash)a)
-  # end
 end