Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Conversation

@mydearxym
Copy link
Member

@mydearxym mydearxym commented Apr 30, 2021

  • remove FavoriteXXX
  • remove StarXXX
  • use common upvote/collect to handle
  • rewrite whole CollectFolder logic to replace old FavoriteCategories
  • add new meta to collect folder
  • use macro to refactor
  • refactor codebar and related test units

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #333 (38e8480) into dev (d38603f) will decrease coverage by 0.26%.
The diff coverage is 92.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #333      +/-   ##
==========================================
- Coverage   87.15%   86.88%   -0.27%     
==========================================
  Files         107      101       -6     
  Lines        1331     1304      -27     
==========================================
- Hits         1160     1133      -27     
  Misses        171      171              
Impacted Files Coverage Δ
lib/groupher_server/accounts/achievement.ex 100.00% <ø> (ø)
lib/groupher_server/accounts/delegates/fans.ex 100.00% <ø> (ø)
lib/groupher_server/accounts/user.ex 100.00% <ø> (ø)
lib/groupher_server/accounts/utils/loader.ex 100.00% <ø> (ø)
lib/groupher_server/application.ex 75.00% <ø> (ø)
lib/groupher_server/cms/community.ex 100.00% <ø> (ø)
lib/groupher_server/cms/delegates/article_curd.ex 100.00% <ø> (ø)
lib/groupher_server/cms/post.ex 100.00% <ø> (ø)
lib/groupher_server/cms/repo.ex 100.00% <ø> (ø)
lib/groupher_server/cms/utils/matcher.ex 40.00% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38603f...38e8480. Read the comment docs.

@mydearxym mydearxym merged commit 3b35013 into dev May 5, 2021
@mydearxym mydearxym deleted the common-upvote branch May 5, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants