Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Conversation

pbteja1998
Copy link

@pbteja1998 pbteja1998 commented Nov 29, 2017

  • Added Swagger Documentation API
  • All APIs that are implemented can be viewed in /api-docs route
  • Changed Contributing Guidelines to add about Swagger
  • Removed API.md file

url(r'^admin/', admin.site.urls),
url(r'^', include('books.urls')),
url(r'^$', views.HelloWordView.as_view()),
url(r'^$', schema_view),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the docs route to something like "api-docs", the way you implemented, makes the api documentation as default route of api.coderplex

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will change this

@pbteja1998
Copy link
Author

What about API.md now ? Should I remove it ?

url(r'^', include('books.urls')),
url(r'^$', schema_view),
url(r'^$', views.HelloWordView.as_view()),
url(r'^api-docs$', schema_view),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, are you able to access the api docs at http://localhost:8000/api-docs ? if yes, we are good with this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am able to access them at http://localhost:8000/api-docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect then, if you make the changes for Changed Contributing Guidelines to add about Swagger , its good to go for a merge.

Copy link
Author

@pbteja1998 pbteja1998 Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about API.md ? Should I keep it or remove it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any necessity for 2 Api documentations, its confusing to know which one is up to date. swagger anyways, is live documentation is obviously up to date with out any changes, so you can remove API.md

@pbteja1998 pbteja1998 merged commit 2d96df8 into coderplex-org:develop Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants