[IS-4/feat]: add creation and deletion of queues #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apietroni51
reviewed
Jun 11, 2025
src/response_decoder.ts
Outdated
| import { DeletedQueueInfo, QueueInfo } from "./queue.js" | ||
|
|
||
| interface ResponseDecoder { | ||
| decodeFrom: (receivedMessage: Message, sentMessageId: string) => unknown |
There was a problem hiding this comment.
should this return a Result<T,K>?
There was a problem hiding this comment.
yes, it should return something like Result<unknown, Error>
apietroni51
approved these changes
Jun 11, 2025
apietroni51
deleted the
4-as-a-library-user-i-want-to-create-a-queue-without-using-the-management-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the possibility of creating or deleting queues through the management.
Also an async version of managament close is implemented