fix(sandpack): Manager typings should reflect that id can be undefined in case of react-sandpack #6027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 3d5a5c9 is at https://pr6027.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d5a5c9:
|
danilowoz
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently the manager types suggest id is always defined, which is not the case for react-sandpack. This is a copy from #6021 but instead of only checking this in consumeCache this fixes the manager types to reflect what the state is in react-sandpack as there's some other places where this could cause issues.
Closes #6021
What is the current behavior?
Manager has an id property that is typed as stirng
What is the new behavior?
Manager has an id property that is typed as string, null or undefined