Skip to content

fix: support keepActiveWhileConnected for browser sessions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

fix: support keepActiveWhileConnected for browser sessions #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions src/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,30 @@ export class SandboxSession extends Disposable {
this.pitcherClient.disconnect();
this.dispose();
}

private keepAliveInterval: NodeJS.Timeout | null = null;
/**
* If enabled, we will keep the sandbox from hibernating as long as the SDK is connected to it.
*/
public keepActiveWhileConnected(enabled: boolean) {
if (enabled && !this.keepAliveInterval) {
this.keepAliveInterval = setInterval(() => {
this.pitcherClient.clients.system.update();
}, 1000 * 30);

this.onWillDispose(() => {
if (this.keepAliveInterval) {
clearInterval(this.keepAliveInterval);
this.keepAliveInterval = null;
}
});
} else {
if (this.keepAliveInterval) {
clearInterval(this.keepAliveInterval);
this.keepAliveInterval = null;
}
}
}
}

export class Sandbox extends SandboxSession {
Expand Down Expand Up @@ -281,28 +305,4 @@ export class Sandbox extends SandboxSession {
public async updateHibernationTimeout(timeoutSeconds: number): Promise<void> {
await this.sandboxClient.updateHibernationTimeout(this.id, timeoutSeconds);
}

private keepAliveInterval: NodeJS.Timeout | null = null;
/**
* If enabled, we will keep the sandbox from hibernating as long as the SDK is connected to it.
*/
public keepActiveWhileConnected(enabled: boolean) {
if (enabled && !this.keepAliveInterval) {
this.keepAliveInterval = setInterval(() => {
this.pitcherClient.clients.system.update();
}, 1000 * 30);

this.onWillDispose(() => {
if (this.keepAliveInterval) {
clearInterval(this.keepAliveInterval);
this.keepAliveInterval = null;
}
});
} else {
if (this.keepAliveInterval) {
clearInterval(this.keepAliveInterval);
this.keepAliveInterval = null;
}
}
}
}