fix: tinymce plugin issue #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheabunge
approved these changes
Nov 17, 2025
|
|
||
| 33% { | ||
| transform: rotate(calc(7deg * var(--cs-direction-multiplier))); | ||
| transform: rotate(7deg); |
Member
There was a problem hiding this comment.
What's the purpose behind removing these changes? Were they causing issues?
Member
Author
There was a problem hiding this comment.
No particolar reason. I just synced back the styles from what was in the pro repo. Also maybe a bit easier to understand
| // Base64-encoded version of menu-icon.svg | ||
| const scissorsIcon = | ||
| 'data:image/svg+xml;base64,' + | ||
| 'PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGZpbGw9Im5vbmUiIHZpZX' + |
Member
There was a problem hiding this comment.
I'm a little concerned this dump of base64 code might cause false-positives in security plugins (my concerns may be unfounded)
Member
Author
There was a problem hiding this comment.
I taught about that too.. i wanted to make a function that takes the actual file and encodes it in base64 ar required but somethig wasnt working right, so i ended up doing it like this.. maybe you could help with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
What changed?
.browserslistrcfile to prevent compatibility issuesCode_Snippets\Vendor\to prevent conflicts with other pluginsHow to test?