Thirdy Party Authentication with passport #57
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GitHub - Google
vaibhavdaren
requested changes
Feb 27, 2020
|
|
||
| router.get('/auth/github/callback', | ||
| passport.authenticate('github', { | ||
| failureRedirect: 'http://localhost:3000' |
| failureRedirect: 'http://localhost:3000' | ||
| }), | ||
| (req, res) => { | ||
| res.redirect('http://localhost:3000/dashboard'); |
| 'googleAuth' : { | ||
| 'clientID' : process.env.GOOGLECLIENTID, | ||
| 'clientSecret' : process.env.GOOGLECLIENTSECRET, | ||
| 'callbackURL' : 'http://localhost:4000/auth/google/callback' |
| 'clientSecret' : process.env.GOOGLECLIENTSECRET, | ||
| 'callbackURL' : 'http://localhost:4000/auth/google/callback' | ||
| } | ||
| }; No newline at end of file |
Member
|
@harshithpabbati dont hardcode failure redirect to localhost:3000, because when this goes to production there will be no localhost and this will fail. |
Member
|
@harshithpabbati also, please check why travis is failing. |
Member
|
@harshithpabbati also, the login which you have added to |
devesh-verma
requested changes
Mar 1, 2020
Member
devesh-verma
left a comment
devesh-verma
left a comment
There was a problem hiding this comment.
please make the requested changes.
Member
|
@harshithpabbati hey can you please resolve the conflict. |
Member
|
@harshithpabbati hey are you still willing to work on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend part: codeuino/social-platform-donut-frontend#342