ADD: tests to google oauth #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the google oauth resolver
alkaline-0
requested review from
AGiljanovic,
BMG93,
DrAdamRoe,
Laurin-Notemann,
Till1983,
Tsangington and
zoe-marie
AGiljanovic
requested changes
May 13, 2024
Collaborator
AGiljanovic
left a comment
AGiljanovic
left a comment
There was a problem hiding this comment.
I would also just add in general validation testing against the different email formats, including edge cases and potential security attacks :)
alkaline-0
force-pushed
the
feature/test-google-auth
branch
from
32bef66 to
d59e2b2
Compare
AGiljanovic
approved these changes
May 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code submitted in the branch feature/oauth was not testable.
I refactored the resolver into a helper file in /packages/src/backend/plugins/plugins_helper/googleAuthResolver.ts and exported the resolver to make it testable.
The tests are written in index.test.ts.