Skip to content

Update _app.tsx #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update _app.tsx #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ import { MuiThemeProvider } from '@material-ui/core/styles';
import CssBaseline from '@material-ui/core/CssBaseline';
import JssProvider from 'react-jss/lib/JssProvider';
import Typography from '@material-ui/core/Typography';
import "react-multi-carousel/lib/styles.css";
import "react-multi-carousel/lib/styles.c";
Copy link

@coderabbitai coderabbitai bot May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect file extension in import statement.

- import "react-multi-carousel/lib/styles.c";
+ import "react-multi-carousel/lib/styles.css";

The import path for the CSS file seems to have a typo in the file extension. It should likely be .css instead of .c. Please verify the correct path and update accordingly.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
import "react-multi-carousel/lib/styles.c";
import "react-multi-carousel/lib/styles.css";


import Menu from '../components/menu';
import getPageContext from '../src/getPageContext';

class MyApp extends App {
class MyApp extends NewChange {
Copy link

@coderabbitai coderabbitai bot May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class inheritance issue.

- class MyApp extends NewChange {
+ class MyApp extends App {

The class MyApp should typically extend from App in Next.js applications. The change to extend from NewChange seems incorrect unless NewChange is a new class that replaces App functionality. Please verify and revert if necessary.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
class MyApp extends NewChange {
class MyApp extends App {

constructor() {
super();
this.pageContext = getPageContext();
Expand Down Expand Up @@ -55,4 +55,4 @@ class MyApp extends App {
}
}

export default MyApp;
export default NewChange;
Copy link

@coderabbitai coderabbitai bot May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Export statement inconsistency.

- export default NewChange;
+ export default MyApp;

The export statement should match the class name defined in the file. Since the class is still named MyApp, the export statement should also reflect this. Please correct the export statement to match the class name.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
export default NewChange;
export default MyApp;