Skip to content

Bandwidth payments #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Add a run-time start-up switch -s/--store-backend to choose the data store backend
merged 42 commits into from
Jun 7, 2021
Merged

Bandwidth payments #9

merged 42 commits into from
Jun 7, 2021

Conversation

@markspanbroek
Copy link
Contributor

@markspanbroek markspanbroek commented Apr 7, 2021 •
edited
Loading

Adds rudimentary payments for bandwidth. Rationale for the design can be found in the RFC.

What it does:

  • it broadcasts a peer's Ethereum account
  • it broadcasts the price for downloading a chunk
  • opens payment channels between peers
  • it pays peers for received chunks

What it doesn't do yet:

  • check that chunk prices are acceptable
  • check whether received chunks were actually requested
  • stop sending chunks when payments are withheld
  • check whether payment channel is backed up by funds on blockchain
  • close payment channels
  • top up payment channels
  • use virtual payment channels

@markspanbroek
Add missing test
6a057a2
@markspanbroek
Fix warnings
b8e5f19
@markspanbroek
Remove duplicate requirement
9fb50a3
@markspanbroek
Add package nim-nitro
3daa26f
@markspanbroek
Workaround no longer necessary
8e1995a
@markspanbroek
Remove deprecated libp2p import
bd68f2c
@markspanbroek
Add nitro wallet to BitswapNetwork
e55ac4e
@markspanbroek
Add package questionable
59e19ef
@markspanbroek
protobuf message for bandwidth pricing
3a9066a
@markspanbroek
Add package upraises
70473aa
@markspanbroek
Ensure that encoding of pricing doesn't raise
ac2c7c2
@markspanbroek
protobuf message for state channel updates
c78b460
@markspanbroek
Fix tests on 32 bit platforms
8465660
@markspanbroek
Move pricing and payments into bitswap protobuf message
06766f2 
Only a single message type is forwarded to the rpc handler,
so we add pricing and payment info to that message type.
@markspanbroek
Fix typo
c5ee2d3
@markspanbroek
Add handler for pricing messages
acaa372
@markspanbroek
Add handler for payment messages
0491558
@markspanbroek
Broadcast pricing
1afdf7a
@markspanbroek
Broadcast payment
d0aec00
@markspanbroek
Exchange pricing when connecting to new peer
ba41405
@markspanbroek
Remove dead code
a95e4b0
@markspanbroek
Revert "Add nitro wallet to BitswapNetwork"
6eabd82 
This reverts commit e55ac4e.
@markspanbroek
Add nitro wallet to BitswapEngine
835357b
@markspanbroek
Move peer context into its own module
670b9fb
@markspanbroek
Update to latest versions of nitro and questionable
fd5d370
dryajov
dryajov reviewed Apr 12, 2021
View reviewed changes
@markspanbroek
Use reference semantics for wallets
254bca9
@markspanbroek
Receive payments for blocks that were sent
4b716d2
@markspanbroek
Hard-code asset address
10cef2d 
We're only going to support a single asset for now.
@markspanbroek
Add pricing to block presence messages
4a21d30
@markspanbroek
Add block prices to peer context
ddbe304
@markspanbroek
Update to version 0.9.1 of questionable
a7698e1
@markspanbroek
Simplify test
fae61fb
@markspanbroek
Simplify
57894f0
@markspanbroek
Send block prices
6bc537d
@markspanbroek
Pay per-block price instead of per-peer price
5488ef0
@markspanbroek
Remove debt ratio
66d5172 
Rationale: selecting peers based on debt ratio in bytes
is no longer needed when the bandwidth for each chunk is
compensated.
@markspanbroek
Remove double bookkeeping in peerHave and peerPrices
b3fbe89
@markspanbroek
Replace pricing exchange by account exchange
8ef6787 
Rationale: price is no longer set per peer, but per chunk.
Only the Ethereum accounts of the peers needs to be exchanged.
@markspanbroek markspanbroek marked this pull request as ready for review May 10, 2021 14:47
@markspanbroek markspanbroek merged commit 6bd4260 into main Jun 7, 2021
@markspanbroek markspanbroek deleted the payments branch June 7, 2021 07:50
@markspanbroek markspanbroek mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dryajov dryajov dryajov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markspanbroek @dryajov