fix(lint): sync remaining ruff --fix output to public repo#32
Merged
Conversation
Backend lint: Ruff 0.x bumped its default ruleset (TC* family alone fired 300+ warnings). Curated the ignore list down to rules that are either established style preferences on this codebase, false positives, or not worth blocking CI: * TCH (typing-only imports — would require restructuring 100+ files) * B008/904 (FastAPI Depends() defaults / except-from-raise chains) * S101/104/105/110/311/324/607/608 (assertions, 0.0.0.0 bind, etc.) * S105 (false positives on fixtures) * T201 (kept in CLI commands) * F841 (sometimes intentional for documentation) * A002 (`format` as parameter name is intentional) * Various N*, C4*, SIM*, UP046 (stylistic) Per-file: tests/ keep S* ignored; CLI keeps T201/B008. Test conftest: dropped unused `admin`/`reader` variable bindings — the test users are looked up later by email, the assignments were documentation. `# noqa` would be noisier than the change itself. Frontend install: react-intl 10 declares a peer dep on @types/react@19, this project is on React 18 / @types/react@18 (which works fine at runtime). Add web/.npmrc with `legacy-peer-deps=true` so plain `npm install` succeeds in CI without bespoke flags.
…01, UP017/UP035) These auto-fixes were generated locally but not synced to the public repo on the previous commit. They are pure cleanup: * F401 — remove unused imports. * I001 — re-sort import blocks. * RET501 — drop `return None` at end of functions. * UP017 — `datetime.timezone.utc` → `datetime.UTC`. * UP035 — deprecated typing imports (`typing.List` → `list`, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix PR (#31) updated the ruff config but I forgot to sync the 84 source files that
ruff --fixhad modified locally. This PR catches them up so CI passes.Pure auto-fixes:
return Nonedatetime.timezone.utc→datetime.UTCVerified locally:
ruff checkpasses,ruff format --checkpasses, 328 tests pass with 82.06% coverage.