fix: register deadline for tree values when ttl is informed#8
Merged
Farenheith merged 1 commit intomainfrom Oct 1, 2023
Merged
fix: register deadline for tree values when ttl is informed#8Farenheith merged 1 commit intomainfrom
Farenheith merged 1 commit intomainfrom
Conversation
Farenheith
force-pushed
the
fix-custom-ttl
branch
from
1416f54 to
85ed194
Compare
Farenheith
force-pushed
the
fix-custom-ttl
branch
from
85ed194 to
2e32467
Compare
codibrebot
pushed a commit
that referenced
this pull request
Oct 1, 2023
## [0.8.1](v0.8.0...v0.8.1) (2023-10-01) ### Bug Fixes * register deadline for tree values when ttl is informed ([#8](#8)) ([332c85f](332c85f))
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom ttl weren't work as expected when values must be saved on tree nodes, as the storage ttl was the only expiration control.
Now, the deadline for each saved node is saved according to the informed ttl (when it is informed)
Also, getCurrentTtl is specified on the storage interface so the library can elect between the current ttl left and the custom one informed, to guarantee that the key will be kept at least for the duration of the latest key to be expired