Skip to content
This repository was archived by the owner on Nov 23, 2022. It is now read-only.

Conversation

@DerMolly
Copy link
Member

@DerMolly DerMolly commented Oct 10, 2020

Component/Part

types

Description

This PR removes our own types and uses the ones from the markdown-it-toc-done-right repo. This can be merged when nagaozen/markdown-it-toc-done-right#40 was merged and published

Steps

  • added implementation

Related Issue(s)

nagaozen/markdown-it-toc-done-right#40

@DerMolly DerMolly mentioned this pull request Oct 10, 2020
19 tasks
@DerMolly DerMolly changed the title changed the usage from our own types to the types of the plugin changed the usage from our own types to the types of the markdown-it-toc-done-right plugin Oct 10, 2020
@DerMolly DerMolly changed the title changed the usage from our own types to the types of the markdown-it-toc-done-right plugin use types from markdown-it-toc-done-right plugin Oct 10, 2020
@mrdrogdrog
Copy link
Member

The related PR was merged. Can you fix this PR?

@DerMolly
Copy link
Member Author

the problem is they still didn't release the new version on npm…

@DerMolly DerMolly force-pushed the fix/useTocDoneRightTypes branch from 608ec01 to a7af734 Compare October 30, 2020 21:27
@DerMolly DerMolly force-pushed the fix/useTocDoneRightTypes branch from a7af734 to 45b3209 Compare November 22, 2020 18:17
@DerMolly DerMolly marked this pull request as ready for review November 22, 2020 18:17
@DerMolly DerMolly self-assigned this Nov 22, 2020
@DerMolly
Copy link
Member Author

and now they did 🎉

Signed-off-by: Philip Molares <philip.molares@udo.edu>
@DerMolly DerMolly force-pushed the fix/useTocDoneRightTypes branch from 45b3209 to d6c1328 Compare November 22, 2020 20:56
Signed-off-by: Philip Molares <philip.molares@udo.edu>
@DerMolly DerMolly merged commit c09aaf0 into main Nov 23, 2020
@DerMolly DerMolly deleted the fix/useTocDoneRightTypes branch November 23, 2020 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants