Dashboard UI #28
Dashboard UI #28
Conversation
|
Thanks @pushpinderpalsingh, for opening the pull request! 🙌 One of our mentors will review the pull request soon. ✅ Star ⭐ this project and tweet 🐦 about your contributions. |
Pods/Pods.xcodeproj/project.pbxproj
Outdated
| @@ -0,0 +1,2660 @@ | |||
| // !$*UTF8*$! | |||
| { | |||
There was a problem hiding this comment.
@pushpinderpalsingh i don't think so this file will be pushed at all
There was a problem hiding this comment.
the pods folder is not ignored in the developed branch. Can you have a look?
|
@pushpinderpalsingh can you remove all the extra assets that you have added as they not matching with the original set of assets also there are certain padding issues for instance on the top bar continue button would have padding also change that icon also the progress bar course progress isn't matching the mocks neither cards are rounded |
swiftlysingh
force-pushed
the
Dashboard
branch
2 times, most recently
from
12e15ac to
d358e56
Compare
|
I have made the requested changes except for the one with assets. I have no access to assets once I do, I will surely update it. |
|
I have added different gradients for different progress percentage. |
|
https://github.com/coding-blocks/CBOnlineApp/tree/development/app/src/main/res/drawable can you update the drawable as well and align padding according to the original design for android mocks ? |
|
What do you mean by drawable? |
|
I mean assests also if you don't find it here you can get it by downloading them from website as well |
|
I meant assets.
…On Sun, Aug 2, 2020, 11:34 AM Pushpinder Pal Singh ***@***.***> wrote:
What do you mean by drawable?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6KGSRPGPNBYQDQJYYD3YTR6T6WZANCNFSM4PB4KTVA>
.
|
|
You need me to update the course progress image? And continue button padding? |
|
Correct alao some padding for progress bar as well |
Signed-off-by: Pushpinder Pal Singh <pushpinderpal19@gmail.com>
|
The link you sent me for assets, I am unable to find any png related to course progress. I did find a default profile image tho should I use that? |
Signed-off-by: Pushpinder Pal Singh <pushpinderpal19@gmail.com>
Signed-off-by: Pushpinder Pal Singh <pushpinderpal19@gmail.com>
Signed-off-by: Pushpinder Pal Singh <pushpinderpal19@gmail.com>
Signed-off-by: Pushpinder Pal Singh <pushpinderpal19@gmail.com>
|
Update Dashboard as requested
|
|
Looks much better now but still got a few nits will update in few minutes.
…On Sun, Aug 2, 2020, 9:45 PM Pushpinder Pal Singh ***@***.***> wrote:
Update Dashboard as requested
[image: Screenshot 2020-08-02 at 9 44 16 PM]
<https://user-images.githubusercontent.com/47032662/89127193-6ab6ac80-d509-11ea-8aa7-1bcf296844e1.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6KGSWLT7VC7GMFGOHLKTTR6WGJ3ANCNFSM4PB4KTVA>
.
|
3 participants
The UI for the Dashboard is complete. With WIP UIs for Library, Doubts, and MyCourses.