SearchBox for Questions #5
Conversation
|
Solves #2 |
| yield timeout(250) | ||
| const questions = yield this.get('store').query('question', { | ||
| include: 'user', | ||
| page: { |
There was a problem hiding this comment.
remove the page qp here, we don't want to have current pagination applied to the filtered response instead, pagination params should reset when filtering.
|
|
||
| if(searchStr === '') { | ||
| pageOpts = { | ||
| number: 1, |
There was a problem hiding this comment.
We don't use number, we use offset based pagination for the backend.
Just skip the pagination part for now altogether as it is not directly related to this PR.
There was a problem hiding this comment.
Done! Pagination part removed when search box is not empty. Pls note that the line mentioned by you above works for empty string (ie when searchbox is made empty). In this case, the default pagination behavior is restored. So, if I remove pageOpts from here, all the results will be displayed (instead of only 10 results).
firefinchdev
force-pushed
the
filter-ques
branch
from
94539c1 to
2b19e1d
Compare
firefinchdev
force-pushed
the
filter-ques
branch
from
2b19e1d to
316f5fa
Compare
|
@abhishek97 |
firefinchdev
force-pushed
the
filter-ques
branch
from
c0b4cdf to
12f90d5
Compare
|
@firefinchdev The functionality works fine. Just place the search box in a new line and center align with an appropriate title. |
|
Done |
2 participants
Done
@abhishek97 Pls Review.