-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
At the moment current table implementation is unusable.
It is not following basic SOLID concepts.
- Every time we want to create new view based on this table it will be required to change current implementation not extend it (Open Closed Principal)
- If we would like to add new property column it will also require to change current implementation. What is worst it needs to be changed in several unrelated places in code (header row is in different place then data rows)
- Communication between action buttons and rows selections is using React Context which makes it invisible where this state is passed (hard to make some customization between pages)
- We have no tests that everything works smoothly after some minor or major refactoring
- Table is dependent on current url- it should not
Requirements for new implementation
- New implementation should not be tied up to data that is presented
- It should have nicely configurable action bar (which action is available on current state of the table)
- allow to add custom actions where needed (Join button on timetable view)
- Sorting should be available after customization on certain properties
- selection should not be a part of entry which is displayed in a row but it should be inherent table mechanism (we should be able to turn off/tun on it if needed)
Metadata
Metadata
Assignees
Labels
No labels