Feat: Basic languages page #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegration test cases
sjaghori
requested changes
Sep 7, 2024
Collaborator
sjaghori
left a comment
sjaghori
left a comment
There was a problem hiding this comment.
Thank you for the PR 🚀
There are some minor issues with the validation, woud you like to have a look at that?
sjaghori
previously approved these changes
Sep 28, 2024
Collaborator
sjaghori
left a comment
sjaghori
left a comment
There was a problem hiding this comment.
Great job! 🚀 I think we can merge this already.
There are just three things we should discuss:
- IMO it makes more sense to automatically select the fallback language when a user adds a new language. It is perfectly fine to give them the option to deselect the fallback language or choose another fallback language.
- We should consider renaming base language to default language
- Adding a modal when there are unsaved changes or removing the save option, adding the functionality for what you see is what is in the db.
Collaborator
|
Oh and please add a little margin of 1rem (mt-4) between the selector and the table:
|
Contributor
Author
Will create a follow up PR for your third point. Will introduce both, improved save button state as well as the modal if there are stale changes. Moreover, I will set a the base language as fallback after creating a new language. |
sjaghori
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic languages page including the following features:
What is missing and will be done in a subsequent PR:
Fallback language input field as select with available optionsConfirmation Modal before deleting a language