Skip to content

(feat) projects overview page #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 5, 2024
Merged

(feat) projects overview page #84

merged 21 commits into from
Jul 5, 2024

Conversation

@benjaminstrasser
Copy link
Member

@benjaminstrasser benjaminstrasser commented Jun 4, 2024 •
edited
Loading

Depends on #77

@benjaminstrasser benjaminstrasser requested a review from mledl as a code owner June 4, 2024 20:34
@benjaminstrasser benjaminstrasser marked this pull request as draft June 4, 2024 20:34
@benjaminstrasser benjaminstrasser mentioned this pull request Jun 4, 2024
Open
4 tasks
@benjaminstrasser benjaminstrasser changed the base branch from main to sidebar June 5, 2024 16:16
@benjaminstrasser benjaminstrasser changed the title Projects Overview Page (feat) projects overview page Jun 6, 2024
Base automatically changed from sidebar to main June 7, 2024 12:56
mledl
mledl reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@mledl mledl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work - our first page 💯
I think we can discuss how we handle state in the path.

@benjaminstrasser
Copy link
Member Author

benjaminstrasser commented Jun 8, 2024

Do we want to add backend integration with this PR or move it to another one to keep each smaller?

@benjaminstrasser benjaminstrasser force-pushed the projects-overview branch 7 times, most recently from 174adaf to ee253c1 Compare June 16, 2024 13:35
@benjaminstrasser benjaminstrasser marked this pull request as ready for review June 16, 2024 14:04
@sjaghori sjaghori mentioned this pull request Jun 17, 2024
Merged
@benjaminstrasser
Copy link
Member Author

benjaminstrasser commented Jun 17, 2024

@sjaghori
I will add an e2e test once #98 is merged to allow for multiple e2e tests.

@benjaminstrasser benjaminstrasser mentioned this pull request Jun 18, 2024
Merged
sjaghori
sjaghori reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@sjaghori sjaghori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just some suggestions.

@benjaminstrasser
Added header to projects
8f4366e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added basic card layout and design
8fb54c3 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added basic navigation
29251b3 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added popover to project card
547cb8a 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added shadcn dialog
383e43d 
added create project dialog and form

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
fixed type errors in autogenerated dialog component
6bd620b 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
removed unnecesarry comment
6c552fa 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added description to create project dialog
e2a9a57 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added project backend functionality
dc7729e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added getAllProjects to repository
37f7c7b 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added getAllProject to porject service
7c041d3 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added getAllProjects to frontend
c12ceee 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
fixed timezone issue
0472b7a 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
rearranged route components into components/container folder
e009a35 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added empty projects view
c4da4da 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser benjaminstrasser requested a review from jjnp as a code owner June 30, 2024 11:27
@benjaminstrasser
added e2e test to create project
f0e547e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser benjaminstrasser mentioned this pull request Jun 30, 2024
Open
@benjaminstrasser
moved project card into seperate component
b0a86a8 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
fixed a bug with language codes and added user form error if name is …
959733c 
…already in use

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
imporved grid layout
55f86cd 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser benjaminstrasser mentioned this pull request Jul 1, 2024
Open
jjnp
jjnp previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jjnp jjnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes. I'll approve, so you can fix them an merge right away

@benjaminstrasser
feedback
6e0899c 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added domain model for Project
0f7315f 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Copy link
Member Author

benjaminstrasser commented Jul 3, 2024

@jjnp @sjaghori

In my opinion, this PR is complete. Would love a last look to see if everything checks out. The only remaining feedback concerns error handling and logging. Since the PR is already larger than desired, I suggest we create separate issues for logging and error handling. This way, we can implement these in the currently implemented features (auth, projects) more coherently and independently.

@benjaminstrasser benjaminstrasser mentioned this pull request Jul 4, 2024
Merged
@benjaminstrasser benjaminstrasser enabled auto-merge (squash) July 4, 2024 13:43
sjaghori
sjaghori approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@sjaghori sjaghori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! 🚀

@benjaminstrasser benjaminstrasser merged commit bfd71df into main Jul 5, 2024
@benjaminstrasser benjaminstrasser deleted the projects-overview branch July 5, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mledl mledl mledl left review comments

@sjaghori sjaghori sjaghori approved these changes

@jjnp jjnp jjnp left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminstrasser @jjnp @mledl @sjaghori