Skip to content

Conversation

@chriscoomber
Copy link
Contributor

See #352.

Added example usage with expo.

Configuration which has been applied, which differs from the expo template:

  • switch jsEngine to hermes
  • allow .cjs files (see metro.config.js)
  • polyfill bits of Intl namespace which aren't covered by hermes (hermes includes some support for Intl, but not all)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • [sorry, I had a failure but wasn't sure if it was my environment] Run the tests with pnpm test and lint the project with pnpm lint

Copy link
Collaborator

@ivanhofer ivanhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the PR!

@ivanhofer ivanhofer changed the title [docs] Add Expo react-native and react-native-web example chore: add Expo react-native and react-native-web example Dec 1, 2022
@ivanhofer ivanhofer merged commit d81eff6 into codingcommons:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants