Skip to content

Conversation

@osdiab
Copy link
Contributor

@osdiab osdiab commented Jul 19, 2023

This replaces lodash.merge with just-extend to avoid issues where Vercel's Edge Runtime would crash if you used extendDictionary because dynamic code execution is not supported on the edge. just-extend does not appear to do this so in theory it should be OK.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • i wrote a test, it passes either way. not sure if i did it right or if you'd like more rigorous tests, though.
    • i have not tested this in the edge runtime, nor have i tested this on more complex use-cases. but the existing tests seem to be happy.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link
Collaborator

@ivanhofer ivanhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@ivanhofer ivanhofer changed the title chore: Replace lodash.merge with just-extend fix: replace lodash.merge with just-extend Jul 20, 2023
@ivanhofer ivanhofer merged commit c961aaa into codingcommons:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants