Drop multiprocessing in rendervariations command #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is profered to use asynchronous renders andyways and to do image rendering on optimized works. Therefore, using multiprocessing to simply queue tasks adds more errors than it does good.
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 98.85% 96.25% -2.60%
==========================================
Files 3 5 +2
Lines 87 267 +180
==========================================
+ Hits 86 257 +171
- Misses 1 10 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is profered to use asynchronous renders andyways and to do
image rendering on optimized works. Therefore, using multiprocessing
to simply queue tasks adds more errors than it does good.