Management Command "rendervariations" Does Not Support Custom Storage Classes #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods, setting value to "field.storage" to support cases where the storage class is not the FileField default.
Author
|
Also throwing in a tweak to |
Author
|
Not sure why any of these minor changes would cause CI to fail. Am I missing something? |
Owner
|
@bltravis please add a test and drop the second commit. I froze progressbar2 on master |
bltravis
force-pushed
the
rendervariations-custom-storage-support
branch
from
fc0b717 to
a08a535
Compare
|
|
Owner
|
Released in 2.0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, the
rendervariationsmanagement command does not respect custom storage classes set onStdImageField. This patch adds an extra arg (storage=field.storage) to the dictionaries generated forargsandargs_listin the render methods of the command class, so that the storage class is passed toutils.render_variations. Otherwise, thestorageargument defaults todjango.core.files.storage.DefaultStorage.