Skip to content

Conversation

@amureki
Copy link
Collaborator

@amureki amureki commented Nov 20, 2025

Prometheus client became optional in dramatiq v2:
https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0

I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.

Prometheus client became optional in dramatiq v2:
https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0

I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.
@amureki amureki self-assigned this Nov 20, 2025
Copilot AI review requested due to automatic review settings November 20, 2025 08:51
Copilot finished reviewing on behalf of amureki November 20, 2025 08:52
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.98%. Comparing base (b323762) to head (9046495).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b323762) and HEAD (9046495). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b323762) HEAD (9046495)
9 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #148       +/-   ##
===========================================
- Coverage   97.76%   81.98%   -15.78%     
===========================================
  Files          17       17               
  Lines         805      805               
===========================================
- Hits          787      660      -127     
- Misses         18      145      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Prometheus middleware from the dramatiq broker configuration in the test application settings, aligning with dramatiq v2 where the Prometheus client became optional.

  • Removes "dramatiq.middleware.Prometheus" from the MIDDLEWARE list in DRAMATIQ_BROKER configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amureki
Copy link
Collaborator Author

amureki commented Nov 20, 2025

@codingjoe I couldn't figure this out from the first look.

Broker is now raising exceptions immediately when tasks retry.
So I wonder how should we approach this here.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amureki, for thinking about me and contributing this change <3

@codingjoe
Copy link
Owner

@amureki dramatic tests fail though 🙈

@amureki
Copy link
Collaborator Author

amureki commented Nov 20, 2025

@amureki dramatic tests fail though 🙈

yeah, as I mentioned above, I am not sure how could we proceed here - need to evaluate this more.

I'd need to invest more time into it, but also if you have suggestions, I'd be happy to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants