Skip to content

Conversation

@kkweon
Copy link
Member

@kkweon kkweon commented Jun 25, 2021

  • ExtractArxivIDFromURL
  • ExtractPaperIDs
  • ExtractPRID

These will be used to generate mapping_table.pbtxt from YouTube Playlist.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #127 (d5eaed3) into main (2589aff) will decrease coverage by 1.83%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   54.90%   53.07%   -1.84%     
==========================================
  Files          10       10              
  Lines         204      228      +24     
==========================================
+ Hits          112      121       +9     
- Misses         80       93      +13     
- Partials       12       14       +2     
Flag Coverage Δ
metadata-manager 43.97% <37.50%> (-1.33%) ⬇️
server 67.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metadata-manager/internal/transform/transform.go 59.61% <37.50%> (-18.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2589aff...d5eaed3. Read the comment docs.

@kkweon kkweon force-pushed the feat-genmapping branch 2 times, most recently from 6f062c4 to bf29301 Compare June 25, 2021 05:31
@kkweon kkweon enabled auto-merge (squash) June 25, 2021 05:32
- ExtractArxivIDFromURL
- ExtractPaperIDs
- ExtractPRID

These will be used to generate mapping_table.pbtxt from YouTube Playlist.
@kkweon kkweon force-pushed the feat-genmapping branch from bf29301 to d5eaed3 Compare June 25, 2021 05:34
Copy link
Contributor

@nicewook nicewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkweon kkweon merged commit 558a01e into main Jun 25, 2021
@kkweon kkweon deleted the feat-genmapping branch June 25, 2021 05:41
@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants