Skip to content

Conversation

@kkweon
Copy link
Member

@kkweon kkweon commented Jun 25, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #128 (d25c42a) into feat-genmapping (d5eaed3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           feat-genmapping     #128   +/-   ##
================================================
  Coverage            53.07%   53.07%           
================================================
  Files                   10       10           
  Lines                  228      228           
================================================
  Hits                   121      121           
  Misses                  93       93           
  Partials                14       14           
Flag Coverage Δ
metadata-manager 43.97% <ø> (ø)
server 67.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5eaed3...d25c42a. Read the comment docs.

- ExtractArxivIDFromURL
- ExtractPaperIDs
- ExtractPRID

These will be used to generate mapping_table.pbtxt from YouTube Playlist.
@kkweon kkweon force-pushed the feat-genmapping branch from bf29301 to d5eaed3 Compare June 25, 2021 05:34
kkweon added 2 commits June 24, 2021 22:35
- ExtractArxivIDFromURL
- ExtractPaperIDs
- ExtractPRID

These will be used to generate mapping_table.pbtxt from YouTube Playlist.
@kkweon kkweon force-pushed the feat-genmapping-2 branch from af96ebc to d25c42a Compare June 25, 2021 05:35
Base automatically changed from feat-genmapping to main June 25, 2021 05:41
@kkweon kkweon enabled auto-merge (squash) June 25, 2021 05:42
Copy link
Contributor

@nicewook nicewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental!

추가되는 유튜브 링크를 받아서 append 하는 방식 말고 이걸 고민해보셨군요.

  1. 플레이리스트를 관리해줘야겠네요
  2. 원하는 컨벤션에 맞지 않는 제목등에 대한 고민이 필요하겠습니다.

@kkweon kkweon merged commit 303dc0a into main Jun 25, 2021
@kkweon kkweon deleted the feat-genmapping-2 branch June 25, 2021 05:45
@github-actions
Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants