feat: serving GPRC GetVideos using dumped pdtxt #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicewook
commented
Jun 6, 2021
nicewook
commented
- client/main.go can test this GRPC function and save response as .pbtxt
- client/main.go can test this GRPC function and save response as .pbtxt
kkweon
requested changes
Jun 6, 2021
nicewook
commented
Jun 6, 2021
Co-authored-by: Mo Kweon <kkweon@gmail.com>
nicewook
commented
Jun 6, 2021
nicewook
commented
Jun 6, 2021
Co-authored-by: Mo Kweon <kkweon@gmail.com>
Co-authored-by: Mo Kweon <kkweon@gmail.com>
Co-authored-by: Mo Kweon <kkweon@gmail.com>
nicewook
commented
Jun 6, 2021
nicewook
commented
Jun 6, 2021
nicewook
commented
Jun 6, 2021
Contributor
Author
|
kkweon
approved these changes
Jun 6, 2021
Member
kkweon
left a comment
kkweon
left a comment
There was a problem hiding this comment.
아주 멋지네요. 👏 👏 👏
린트에러 및 비디오 객체 생성 관련 수정만 해주시면 머지하겠습니다.
Co-authored-by: Mo Kweon <kkweon@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
===========================================
- Coverage 88.70% 77.41% -11.30%
===========================================
Files 3 3
Lines 62 31 -31
===========================================
- Hits 55 24 -31
Misses 6 6
Partials 1 1
Continue to review full report at Codecov.
|
Member
|
수고하셨습니다 |
Contributor
Author
|
감사합니다. (__) |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.