Naggum.Assembler #30
Merged
Naggum.Assembler #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ForNeVeR
force-pushed
the
feature/nga
branch
from
6a75c6a to
db62604
Compare
Member
Author
|
@gsomix, the rebase is done, please take a look at this. |
Member
Author
|
I've rebased these changes against latest |
Merged
Member
Author
|
Well, I'll review it myself. Sorry, mr. @gsomix, but we need to move on with that. I hope you'll be able to catch up new pull requests later. |
Naggum.Assembler/Assembler.fs
Outdated
Member
Author
There was a problem hiding this comment.
Should we really add method overload resolution here? I doubt: here the user has written the method exactly as he wants it to be resolved, without any compiler-involved resolution step.
Naggum.Assembler/Processor.fs
Outdated
Member
Author
There was a problem hiding this comment.
Please define argument types for public API.
ForNeVeR
added a commit
that referenced
this pull request
Jan 4, 2016
Assembler: initial implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #19 I am starting my work through assembler. It will become more feature-rich in future (the next big thing should be the macro subsystem while it may take a few additional steps to add some of the missing instructions), but that't the first little step.
Also I've renamed all the executable assemblies to use the more appropriate names (
Naggum.Compiler,Naggum.Interactive). I think we'll create a platform-dependent convenience scripts with shorter names in future (nga,ngcandngitrinity would be nice).