Insert character in every selected tile

[vacuumbeef]

In orca-c and orca-uxn when you select multiple tiles and type a character - it inserts the character in every selected tile. In JS and o2 implementations it only inserts the character in the first selected tile.

I personally find the orca-c/uxn way extremely useful, especially when you need to do wiring with J/Y. So I wonder if it could be implemented in o2 too?

[vacuumbeef]

I ended up implementing it myself and it surprisingly works - vacuumbeef@e1bee0c
I also changed Append to work like in orca-c/uxn:

Current o2 on main (as well as Orca-JS):

In append mode if the glyph under the cursor is same you are inserting - it will not insert it.

Orca-C, Orca-UXN:

In append mode it will not check for glyphs under the cursor, so it does not block you from writing

@coignard can you please look. What do you think about this? And if you like it is it good enough for a pr?

[coignard]

Hi, looks very promising, thank you!

Btw checking if self.mode == InputMode::Normal will break typing if the user is explicitly in InputMode::Selection (by pressing ') or InputMode::Slide (by pressing ~).

I would suggest something like:

pub fn write_cursor(&mut self, g: char) {
        let allowed_g = if Self::is_allowed(g) { g } else { '.' };

        if self.mode == InputMode::Append {
            if let Some(idx) = self.index_at(self.cursor.cx, self.cursor.cy) {
                self.o2.cells[idx] = allowed_g;
                self.move_cursor(1, 0);
                self.history.record(&self.o2.cells);
            }
        } else {
            let mut changed = false;

            for y in self.cursor.min_y..=self.cursor.max_y {
                for x in self.cursor.min_x..=self.cursor.max_x {
                    if let Some(idx) = self.index_at(x, y) {
                        if self.o2.cells[idx] != allowed_g {
                            self.o2.cells[idx] = allowed_g;
                            changed = true;
                        }
                    }
                }
            }

            if changed {
                self.history.record(&self.o2.cells);
            }
        }
    }

Feel free to open a PR if needed.

René Coignard