feat: Add support for deploying arbitrary contracts #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-agarwal-coinbase
requested review from
0xRAG,
John-peterson-coinbase and
jazz-cb
🟡 Heimdall Review Status
|
0xRAG
approved these changes
Jan 17, 2025
Contributor
Author
|
Merging despite e2e tests failing since they look unrelated and flaky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
deploy_contractin wallet_address.py and wallet.py to support deploying an arbitrary contract using the compiler version, solidity input json, contract name of the class to be deployed, and constructor argumentsTesting
Qualified Impact