Skip to content

Conversation

@tacman
Copy link
Contributor

@tacman tacman commented Nov 22, 2024

Description

Some minor tweaks.

Motivation and context

  • Added php 8.4 to testing
  • updated phpstan to 2.0
  • fixed a tiny issue identified phpstan (casting a bool)
  • fixed a missing quote in the github workflow

How has this been tested?

Using github actions.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • [ x] I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change adds a new code file, I have added the copyright header to it.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Copy link
Owner

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@colinodell colinodell merged commit 8d56f60 into colinodell:main Nov 25, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants