register the adapter instead of the @login endpoint#73
Merged
Conversation
davisagli
requested changes
Jan 21, 2025
Member
Author
|
I had to override some versions because in local testing it was using the plone.restapi version coming from Plone 6.0.14, and I got some strange error regarding the |
ericof
approved these changes
Feb 3, 2025
Member
Author
done |
davisagli
reviewed
Feb 3, 2025
Member
davisagli
left a comment
davisagli
left a comment
There was a problem hiding this comment.
I'd suggest adding a minimum plone.restapi version here, otherwise it's breaking: https://github.com/collective/pas.plugins.authomatic/blob/main/pyproject.toml#L41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be used with plone/plone.restapi#1757