Skip to content

Conversation

@calvinl
Copy link
Member

@calvinl calvinl commented Jun 16, 2016

Re: #14

  • Reimplement Cordova support with ES2015
  • Cleaner configuration than before
  • Change npm run script names to shorter environment names

process.chdir('./cordova');

// build with options and distribute to Fabric if specified
return cordova.raw.build(buildOpts).then(function() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to add here information when promise failed so

  return cordova.raw.build(buildOpts).then(function() {
    if (distribute) {
      fabric.distribute(platforms, target);
    }
  }, function (error) {
    console.log('Build failed', error);
  });
};

@marcelijanowski
Copy link

marcelijanowski commented Jun 26, 2016

Also I try to run build scripts with fabric and getting error:

cordova:dist:android

And then getting an error when I little bit modify your code (example above):

Build failed { CordovaError: Current working directory is not a Cordova-based project.

How can I fix it as it's looking for cordova folder plus it need some build.json file which really I don't know how it looks , some example maybe?

@calvinl
Copy link
Member Author

calvinl commented Jun 27, 2016

@marcelijanowski - I'll take a look at that shortly, but you can use release.json.example - it's the same as build.json. Or look at the cordova docs: https://cordova.apache.org/docs/en/latest/guide/platforms/android/#using-buildjson (Android)

@calvinl calvinl merged commit 5b17b8c into master Aug 15, 2016
@calvinl calvinl deleted the feature/cordova branch August 15, 2016 19:07
@calvinl calvinl restored the feature/cordova branch August 31, 2016 02:40
@calvinl calvinl deleted the feature/cordova branch October 27, 2016 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants