feat: /edu에 따른 next화가 되어 menu마다 nuxt값을 확인하여 링크 이동할 수 있도록 변경#1174
Merged
hananumber1 merged 1 commit intodevelopfrom Dec 5, 2024
Merged
feat: /edu에 따른 next화가 되어 menu마다 nuxt값을 확인하여 링크 이동할 수 있도록 변경#1174hananumber1 merged 1 commit intodevelopfrom
hananumber1 merged 1 commit intodevelopfrom
Conversation
hananumber1
requested review from
LuiGeeDev,
comento,
donghoon-song,
mong-byte and
yooseongsil
as code owners
donghoon-song
approved these changes
Dec 3, 2024
LuiGeeDev
reviewed
Dec 3, 2024
Collaborator
LuiGeeDev
left a comment
LuiGeeDev
left a comment
There was a problem hiding this comment.
여기는 라라벨에서 a 태그 쓰려고 하는건데 라라벨에 이거 적용됐을 때 문제 없을까요?
Collaborator
Author
오호 라라벨 한번 더 췤 해볼게요! |
mong-byte
approved these changes
Dec 4, 2024
yooseongsil
approved these changes
Dec 4, 2024
hananumber1
added a commit
that referenced
this pull request
Dec 5, 2024
* 아이콘 최신화 (#1171) * feat: 아이콘 최신화 * chore: path fill=black 제거 * feat: icon component 이름 변경 * fix: path fill black 제거 * chip 수정사항 반영 (#1170) * fix: clickable에 해당하는 스타일 수정 및 error 타입일 경우 red800 return 해야하는 케이스 반영 * fix: 조건문 수정 * fix: 피드백 반영 * feat: /edu에 따른 next화가 되어 menu마다 nuxt값을 확인하여 링크 이동할 수 있도록 변경 (#1174) --------- Co-authored-by: 김민기 <75971035+mong-byte@users.noreply.github.com> Co-authored-by: 김민기 <tkg78912@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/comento/comento-libs/pull/104 같이 반영되어야 하는 친구입니다!