Add support for PEP568 (fixes #15) #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiter
force-pushed
the
pep563-compat
branch
from
3a17c85 to
27cff2e
Compare
jbaiter
force-pushed
the
pep563-compat
branch
from
27cff2e to
6360935
Compare
comfuture
approved these changes
Nov 20, 2024
Owner
comfuture
left a comment
comfuture
left a comment
There was a problem hiding this comment.
The changes do not affect existing functionality and seem to resolve the issue. 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the fix suggested in #15.
When PEP568 is enabled via
from __future__ import annotations, type hints are only available in their string form when obtained viatyping.get_argson the parameter. To obtain the actual hints, one needs to usetyping.get_type_hintson the function itself.