Support for Classic non-AP Tesla Model S #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zax123 I see 2 Tesla PRs. Is one obsolete? |
|
I asked @zax123 to update this one or make a new one with just the basic safety numbers so its easy for you to merge without any risks. Those files: https://github.com/commaai/openpilot/blob/devel/selfdrive/boardd/boardd.cc#L34-L43 and associated files in Panda: https://github.com/commaai/panda/blob/master/board/safety.h#L42-L52 |
|
Close this one and switch to #296 |
pd0wm
pushed a commit
that referenced
this pull request
May 13, 2020
11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 11343c108649dda898992cfdcc3298248f3d82f7
pd0wm
pushed a commit
that referenced
this pull request
May 29, 2020
0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 0430bfa5c2b08f9cc6ab32470fe8ac9465e7a876
pd0wm
pushed a commit
that referenced
this pull request
May 31, 2020
e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: e92e74311a7ed66922629bec4b8cee7c8db1b9f0
pd0wm
pushed a commit
that referenced
this pull request
May 31, 2020
4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 4c59163aa31b58436fad2f8cbadeacd564887276
pd0wm
pushed a commit
that referenced
this pull request
Jun 1, 2020
1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
pd0wm
pushed a commit
that referenced
this pull request
Jun 1, 2020
1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
zhou13
pushed a commit
to zhou13/openpilot
that referenced
this pull request
Dec 18, 2021
Lower octave w/ base, treble, and amplitude tweaks
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes to openpilot necessary to support Classic non-AP Tesla Model S with harness as designed by @zax123 and @kalud and a Tesla giraffe on Panda.