Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets enabled var used by steer command to 0 during steer_not_allowed #263

Closed
wants to merge 1 commit into from
Closed

Sets enabled var used by steer command to 0 during steer_not_allowed #263

wants to merge 1 commit into from

Conversation

energee
Copy link
Contributor

@energee energee commented Jun 18, 2018 •
edited
Loading

Regression to ILX due to change required by new Accord.

@energee energee changed the title Sets enabled to 0 during steer_not_allowed Sets enabled var used by steer command to 0 during steer_not_allowed Jun 18, 2018
rbiasini
rbiasini reviewed Jun 18, 2018
View reviewed changes
selfdrive/car/honda/carcontroller.py Outdated
apply_steer = 0
# any other cp.vl[0x18F]['STEER_STATUS'] is common and can happen during user override. sending 0 torque to avoid EPS sending error 5 on ILX
if CS.CP.carFingerprint in (CAR.ACURA_ILX) && CS.steer_not_allowed:
apply_steer, enabled = (0,) * 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm... let me do it a bit better. Need something like we do on the Volt. @energee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

@energee energee closed this Jun 18, 2018
@energee energee deleted the ilx-steer-fault branch September 25, 2018 22:02
pd0wm pushed a commit that referenced this pull request Sep 10, 2019
Squashed 'panda/' changes from 8843af7..9881e61
876256a 
9881e61 Panda for Mazda (#165)
9a15d2f fix version newline
a8ed7d2 add subaru outback/legacy to subaru safety (#259)
bdeb1c9 mazda is #12
14ea4d2 merge safety gm in a single file
bf1ef87 Add GM passive safety mode (#266)
c131fff fix canflash for pedal (#267)
3397b15 only allow bootloader entry on debug builds
d68356b Honda Nidec: fwd stock AEB (#257)
6f532c6 Black panda Jenkins (#256)
d68508c Gpio race condition fix (#263)
d69d05f Fixed pedal not initializing (#262)
36067e0 Honda safety: fixed incorrect brake decoding. Due to the specific limit of 255, this change does not affect the safety behavior

git-subtree-dir: panda
git-subtree-split: 9881e61
Vaggysag pushed a commit to Vaggysag/openpilot that referenced this pull request Apr 21, 2020
@robbederks @rbiasini
Gpio race condition fix (commaai#263)
d68508c 
* Fixed pedal not initializing

* Interrupt changes

* More changes
pd0wm pushed a commit that referenced this pull request May 28, 2020
Squashed 'opendbc/' changes from f1e69a6cf..b49b9ee75
c25791c 
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: b49b9ee75ca103cc0af25fa9d03b87cfd02374f8
pd0wm pushed a commit that referenced this pull request May 28, 2020
Squashed 'opendbc/' changes from f1e69a6cf..b49b9ee75
a694a03 
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: b49b9ee75ca103cc0af25fa9d03b87cfd02374f8
pd0wm pushed a commit that referenced this pull request May 28, 2020
Squashed 'opendbc/' changes from f1e69a6cf..d1185a53e
dd92b7a 
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: d1185a53e5b942a5dda7ddb8c827e23fa667c10a
pd0wm pushed a commit that referenced this pull request May 29, 2020
Squashed 'opendbc/' changes from f1e69a6cf..0430bfa5c
76df409 
0430bfa5c run pre commit in ci (#268)
2ade6eeba Subaru DBC update (#242)
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 0430bfa5c2b08f9cc6ab32470fe8ac9465e7a876
pd0wm pushed a commit that referenced this pull request May 31, 2020
Squashed 'opendbc/' changes from f1e69a6cf..e92e74311
35bd9d9 
e92e74311 whitespace after comma
5d33ec0f1 two spaces before inline comment
73685b609 fix linter complaint about whitespace around operators
b15edbc1b fix linter complaint about inline comment whitespace
4ac30725b clean up blank lines
0430bfa5c run pre commit in ci (#268)
2ade6eeba Subaru DBC update (#242)
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: e92e74311a7ed66922629bec4b8cee7c8db1b9f0
pd0wm pushed a commit that referenced this pull request May 31, 2020
Squashed 'opendbc/' changes from f1e69a6cf..4c59163aa
3e4a769 
4c59163aa two spaces before inline comment
e92e74311 whitespace after comma
5d33ec0f1 two spaces before inline comment
73685b609 fix linter complaint about whitespace around operators
b15edbc1b fix linter complaint about inline comment whitespace
4ac30725b clean up blank lines
0430bfa5c run pre commit in ci (#268)
2ade6eeba Subaru DBC update (#242)
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 4c59163aa31b58436fad2f8cbadeacd564887276
pd0wm pushed a commit that referenced this pull request Jun 1, 2020
Squashed 'opendbc/' changes from f1e69a6cf..1f1ff225b
9ef7ce2 
1f1ff225b enable almost all flake8 checks
4c59163aa two spaces before inline comment
e92e74311 whitespace after comma
5d33ec0f1 two spaces before inline comment
73685b609 fix linter complaint about whitespace around operators
b15edbc1b fix linter complaint about inline comment whitespace
4ac30725b clean up blank lines
0430bfa5c run pre commit in ci (#268)
2ade6eeba Subaru DBC update (#242)
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
pd0wm pushed a commit that referenced this pull request Jun 1, 2020
Squashed 'opendbc/' changes from f1e69a6cf..1f1ff225b
bd2fde8 
1f1ff225b enable almost all flake8 checks
4c59163aa two spaces before inline comment
e92e74311 whitespace after comma
5d33ec0f1 two spaces before inline comment
73685b609 fix linter complaint about whitespace around operators
b15edbc1b fix linter complaint about inline comment whitespace
4ac30725b clean up blank lines
0430bfa5c run pre commit in ci (#268)
2ade6eeba Subaru DBC update (#242)
d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee75 Add DAW (#175)
3b5cccba0 Fixed up cell voltage readings and added more commands (#220)
8b0449327 Mazda: add missing static bits, tidy up endianness  (#263)
124719992 Add BSD_RCTA to Subaru Global (#244)
af1821f84 fix endianness in signal from new hyundai message
7ef41084b Add gas/brake message for hyundai EVs, from @TK211X
472aabb4f Subaru preglobal update (#260)
45c0d9ecc fix lta message (#262)
11343c108 Library cleanup (#261)
67d70cb86 Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
sheldonroth pushed a commit to sheldonroth/openpilot that referenced this pull request Mar 6, 2022
@ErichMoraga
Merge pull request commaai#263 from commaai/devel
f713c67 
0.8.13
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
@sunnyhaibin
Gap Adjust Cruise: Merge with Driving Personality (commaai#263)
b868339 
* Merge Gap Adjust Cruise with Driving Personality

* last bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbiasini rbiasini rbiasini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@energee @rbiasini