-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Compile openpilot on macOS #32909
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
Can you rebase this to get the latest opendbc? |
@maxime-desroches updated. Also probably need to fix the permission issue for the new |
Nice! Can you add a scons cache to make the build faster? You can look how it is done here for our custom ubuntu20.04 cache: https://github.com/commaai/openpilot/blob/master/.github/workflows/tools_tests.yaml#L65 |
|
It's redundant I believe, @cache already automatically saves the cache Also is there any reason why this is in gha of hmm, I think we don't need the save cache step in the ubuntu2004 as well it already saves the cache. also maybe we can put the saving cache flow into a separate step so that we don't have redundant code of calling cache and getting the dates in a separate PR (I believe we have 3 yaml files that do the same thing) |
Feel free to open a pr to clean up the caching in CI. The caching is normally done in setup --> auto-cache when using the docker image, but not when doing these non docker builds like ubuntu20.04 and macOS |
* working * cache * bring back old-commit-hash: 15d3397
resolves: #32885
depends on: commaai/opendbc#1059
gcc@13
replay/util.c