Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Compile openpilot on macOS #32909

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Jul 5, 2024

resolves: #32885

depends on: commaai/opendbc#1059

  1. enabled build in CI
  2. added gcc@13
  3. fixed typo in replay/util.c

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@bongbui321 bongbui321 changed the title CI/tools: Compile openpilot on macOS CI: Compile openpilot on macOS Jul 5, 2024
@maxime-desroches
Copy link
Contributor

Can you rebase this to get the latest opendbc?

@bongbui321
Copy link
Contributor Author

bongbui321 commented Jul 8, 2024

@maxime-desroches updated. Also probably need to fix the permission issue for the new build doc in a separate PR

@maxime-desroches
Copy link
Contributor

Nice! Can you add a scons cache to make the build faster? You can look how it is done here for our custom ubuntu20.04 cache: https://github.com/commaai/openpilot/blob/master/.github/workflows/tools_tests.yaml#L65

@maxime-desroches
Copy link
Contributor

maxime-desroches commented Jul 8, 2024

@bongbui321
Copy link
Contributor Author

bongbui321 commented Jul 8, 2024

It's redundant I believe, @cache already automatically saves the cache

Also is there any reason why this is in gha of selfdrive in the first place? Makes more sense to have this in tools gha

hmm, I think we don't need the save cache step in the ubuntu2004 as well it already saves the cache.

also maybe we can put the saving cache flow into a separate step so that we don't have redundant code of calling cache and getting the dates in a separate PR (I believe we have 3 yaml files that do the same thing)

@maxime-desroches
Copy link
Contributor

Feel free to open a pr to clean up the caching in CI. The caching is normally done in setup --> auto-cache when using the docker image, but not when doing these non docker builds like ubuntu20.04 and macOS

@maxime-desroches maxime-desroches merged commit 15d3397 into commaai:master Jul 8, 2024
15 of 16 checks passed
@bongbui321 bongbui321 deleted the mac_build branch July 8, 2024 23:59
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* working

* cache

* bring back
old-commit-hash: 15d3397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling openpilot on macOS
2 participants