Skip to content

enhancement: Bumped upstream version of eks module and changed variables to support better handling of node group changes, also added missing provider requirements.#52

Merged
bmonkman merged 2 commits intomainfrom
fix-node-group-behaviour
Jun 29, 2021
Merged

enhancement: Bumped upstream version of eks module and changed variables to support better handling of node group changes, also added missing provider requirements.#52
bmonkman merged 2 commits intomainfrom
fix-node-group-behaviour

Conversation

@bmonkman
Copy link
Copy Markdown
Contributor

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

…les to support better handling of node group changes, also added missing provider requirements.

BREAKING CHANGE: The change to the EKS module had its own breaking change that will require a bit of state management, you can read about it here: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/upgrades.md#upgrade-module-to-v1700-for-managed-node-groups . Also, this change may require some state management since it changes the name of the node group. You should be able to upgrade gracefully by importing the previous group into the state and removing the old one. Feel free to ask in the community channel at slack.getzero.dev if you have any questions.
@bmonkman bmonkman requested a review from a team as a code owner June 28, 2021 23:36
@bmonkman bmonkman requested a review from davidcheung June 28, 2021 23:36
@github-actions
Copy link
Copy Markdown

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

@github-actions
Copy link
Copy Markdown

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖Success! The configuration is valid.

@bmonkman bmonkman merged commit ada4275 into main Jun 29, 2021
@bmonkman bmonkman deleted the fix-node-group-behaviour branch June 29, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants