Conversation
…their cluster before this module made a change to the cluster role name
Terraform Format and Style 🖌
|
davidcheung
approved these changes
Aug 19, 2021
…eed to be done in the eks stack kubernetes terraform instead
Terraform Format and Style 🖌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a change introduced in 0.4.3 of this module that stopped specifying the cluster role name, presumably to fix this same issue with clusters created at some point in the past.
The problem we see is that if you create a cluster, and then try to change this role name,
terraform planwill not even succeed, instead you get obscure error messages like this:This change will let older cluster operators upgrade to newer versions of this module while still maintaining the old cluster role name.
Checklist