Merged
Conversation
…to IAM only, don't create aws-auth configmap in eks module
Terraform Format and Style 🖌
|
davidcheung
approved these changes
Dec 16, 2021
bmonkman
added a commit
that referenced
this pull request
Dec 17, 2021
* refactor: remove all k8s stuff from the user_access module, limit it to IAM only, don't create aws-auth configmap in eks module * fix: remove leftover k8s reference * fix: more simplification of user_access code * fix: syntax error in user_auth, added missing reference to k8s assumerole breaking change: This change moves away from creating the aws-auth configmap in the same terraform state where we are creating the cluster. All k8s operations have been moved to the kubernetes terraform in the aws-eks-stack repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking change - Move away from creating the aws-auth configmap in the same terraform state where we are creating the cluster.
https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs#stacking-with-managed-kubernetes-cluster-resources
Remove the iam role to k8s role mapping, as this functionality will be moved into the k8s handling in the aws-eks-stack repo.