feat: make db version configurable. Adds some required fields to the module#72
Merged
feat: make db version configurable. Adds some required fields to the module#72
Conversation
Terraform Format and Style 🖌
|
davidcheung
approved these changes
May 17, 2022
| } | ||
|
|
||
| variable "database_engine_version" { | ||
| description = "Which database version to use. See the aws cli describe-db-engine-versions command for a list of valid versions" |
Contributor
There was a problem hiding this comment.
Suggested change
| description = "Which database version to use. See the aws cli describe-db-engine-versions command for a list of valid versions" | |
| description = "Which database version to use. See the aws rds describe-db-engine-versions command for a list of valid versions" |
Contributor
There was a problem hiding this comment.
should these be aws rds describe-db-engine-versions instead?
Contributor
Author
There was a problem hiding this comment.
I meant to check the command in the aws cli, but yeah that works too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here and link to any relevant issues.
Checklist