Skip to content

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Jun 1, 2022

Extend our manual parser to handle string values that use single or
double quotes. The support is limited and doesn't implement the full
YAML spec (e.g. no support for escapes like \n).

At some point we should either depend on a real YAML parser or expose
the raw YAML source so that users can parse it themselves.

Fixes #260.

Extend our manual parser to handle string values that use single or
double quotes. The support is limited and doesn't implement the full
YAML spec (e.g. no support for escapes like `\n`).

At some point we should either depend on a real YAML parser or expose
the raw YAML source so that users can parse it themselves.

Fixes #260.
@codecov-commenter
Copy link

Codecov Report

Merging #261 (4785dec) into main (adae79c) will decrease coverage by 0.03%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##               main     #261      +/-   ##
============================================
- Coverage     94.21%   94.17%   -0.04%     
- Complexity      220      223       +3     
============================================
  Files           124      124              
  Lines          3593     3604      +11     
  Branches        542      543       +1     
============================================
+ Hits           3385     3394       +9     
  Misses          104      104              
- Partials        104      106       +2     
Impacted Files Coverage Δ
...nt/matter/internal/YamlFrontMatterBlockParser.java 94.91% <86.66%> (-3.01%) ⬇️

@robinst robinst merged commit 472812b into main Jun 2, 2022
@robinst robinst deleted the yaml-quoted-strings branch June 2, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YAML front matter parser does not strip single or double quotes on scalars

2 participants