-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
Summary
Many years ago, @bvibber made the files app/src/main/res/xml/wikimedia_licenses.xml and update-license-info/licenses.php.
update-license-info/licenses.php tries to read license data from the localization files of the MediaWiki extension UploadWizard, but it won't work today because the localization files' format completely changed in 2014.
It's probably not really a problem because I can't find where is wikimedia_licenses.xml used, although perhaps I'm not searching correctly.
I noticed this because Android Studio reports a lint error about the URL in the beginning of wikimedia_licenses.xml. That URL is https://www.mediawiki.org/wiki/Extension:UploadWizard/xmlns/licenses , which is a page that was also created by @bvibber 12 years ago, never changed since then, and not having any substantial content.
Can these two files perhaps be removed? They are also mentioned in the build configuration, but it's unclear for what purpose.
Steps to reproduce
Run Code -> Inspect Code in Android Studio.
Expected behaviour
- There should be no errors about the file wikimedia_licenses.xml.
- There should be not unused files.
Actual behaviour
- There is an error about the file wikimedia_licenses.xml.
- This file, and update-license-info/licenses.php, which creates it, seem to be unused and outdated.
Device name
it's in the code
Android version
Commons app version
current main source
Device logs
No response
Screenshots
No response
Would you like to work on the issue?
Yes