Remove an unused element from layout/fragment_media_detail.xml #6536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this issue years ago because it used a hard-to-understand string that needed better documentation (see commons-app#688). I forgot it, but recently, I started to explore the app much more deeply and came back to it. It looks like this string is only used in this layout element, but the element itself is not used anywhere. It usage appears to have been removed in commons-app#634.
amire80
force-pushed
the
mediaimage_failed
branch
from
5b33697 to
710b525
Compare
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
I noticed this issue years ago because it used a hard-to-understand string that needed better documentation (see #688). I forgot it, but recently, I started to explore the app much more deeply and came back to it.
It looks like this string is only used in this layout element, but the element itself is not used anywhere. Its usage appears to have been removed in #634.
This fixes #688 by removing the message in question.
(Comment: I previously submitted it as #6511, but deleted the branch by mistake.)
Tests performed (required)
Tested the layout that uses it in Android Studio emulator, everything works as it did previously.